refactor: native feature management (#2350)

packages/services/src/Domain/Feature/FeaturesClientInterface.ts

@@ -1,37 +1,27 @@
 import { FeatureIdentifier } from '@standardnotes/features'
-import { SNComponent } from '@standardnotes/models'
+import { ComponentInterface } from '@standardnotes/models'
 
 import { FeatureStatus } from './FeatureStatus'
 import { SetOfflineFeaturesFunctionResponse } from './SetOfflineFeaturesFunctionResponse'
 
 export interface FeaturesClientInterface {
-  downloadExternalFeature(urlOrCode: string): Promise<SNComponent | undefined>
-
   getFeatureStatus(featureId: FeatureIdentifier): FeatureStatus
-
-  hasFirstPartySubscription(): boolean
-
   hasMinimumRole(role: string): boolean
 
+  hasFirstPartyOfflineSubscription(): boolean
   setOfflineFeaturesCode(code: string): Promise<SetOfflineFeaturesFunctionResponse>
-
   hasOfflineRepo(): boolean
-
   deleteOfflineFeatureRepo(): Promise<void>
 
   isThirdPartyFeature(identifier: string): boolean
 
   toggleExperimentalFeature(identifier: FeatureIdentifier): void
-
   getExperimentalFeatures(): FeatureIdentifier[]
-
   getEnabledExperimentalFeatures(): FeatureIdentifier[]
-
   enableExperimentalFeature(identifier: FeatureIdentifier): void
-
   disableExperimentalFeature(identifier: FeatureIdentifier): void
-
   isExperimentalFeatureEnabled(identifier: FeatureIdentifier): boolean
-
   isExperimentalFeature(identifier: FeatureIdentifier): boolean
+
+  downloadRemoteThirdPartyFeature(urlOrCode: string): Promise<ComponentInterface | undefined>
 }

packages/services/src/Domain/Feature/FeaturesEvent.ts

@@ -1,5 +1,5 @@
 export enum FeaturesEvent {
   UserRolesChanged = 'UserRolesChanged',
-  FeaturesUpdated = 'FeaturesUpdated',
+  FeaturesAvailabilityChanged = 'Features:FeaturesAvailabilityChanged',
   DidPurchaseSubscription = 'DidPurchaseSubscription',
 }

packages/services/src/Domain/Feature/SetOfflineFeaturesFunctionResponse.ts

@@ -1,3 +1,3 @@
 import { ClientDisplayableError } from '@standardnotes/responses'
 
-export type SetOfflineFeaturesFunctionResponse = ClientDisplayableError | undefined
+export type SetOfflineFeaturesFunctionResponse = ClientDisplayableError | void