rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(fix): fixes sync response not correctly identifying all errors (#2346)

Browse Source
This commit is contained in:
Mo
2023-07-05 11:28:45 -05:00
committed by GitHub
parent 2a050fd966
commit 0ab6b5c6fe
19 changed files with 81 additions and 49 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
packages/services/src/Domain/Revision/RevisionManager.ts
View File

@@ -1,6 +1,6 @@
import { RevisionApiServiceInterface } from '@standardnotes/api'
import { Uuid } from '@standardnotes/domain-core'
import { isErrorResponse } from '@standardnotes/responses'
import { getErrorFromErrorResponse, isErrorResponse } from '@standardnotes/responses'
import { InternalEventBusInterface } from '../Internal/InternalEventBusInterface'
import { AbstractService } from '../Service/AbstractService'
@@ -21,7 +21,7 @@ export class RevisionManager extends AbstractService implements RevisionClientIn
const result = await this.revisionApiService.listRevisions(itemUuid.value)
if (isErrorResponse(result)) {
throw new Error(result.data.error.message)
throw new Error(getErrorFromErrorResponse(result).message)
}
return result.data.revisions
@@ -31,7 +31,7 @@ export class RevisionManager extends AbstractService implements RevisionClientIn
const result = await this.revisionApiService.deleteRevision(itemUuid.value, revisionUuid.value)
if (isErrorResponse(result)) {
throw new Error(result.data.error.message)
throw new Error(getErrorFromErrorResponse(result).message)
}
return result.data.message
@@ -41,7 +41,7 @@ export class RevisionManager extends AbstractService implements RevisionClientIn
const result = await this.revisionApiService.getRevision(itemUuid.value, revisionUuid.value)
if (isErrorResponse(result)) {
throw new Error(result.data.error.message)
throw new Error(getErrorFromErrorResponse(result).message)
}
return result.data.revision