chore(fix): fixes sync response not correctly identifying all errors (#2346)

This commit is contained in:
Mo
2023-07-05 11:28:45 -05:00
committed by GitHub
parent 2a050fd966
commit 0ab6b5c6fe
19 changed files with 81 additions and 49 deletions

View File

@@ -1,5 +1,12 @@
import { ViewControllerManager } from '@/Controllers/ViewControllerManager'
import { SNApplication, SessionStrings, UuidString, SessionListEntry, isErrorResponse } from '@standardnotes/snjs'
import {
SNApplication,
SessionStrings,
UuidString,
SessionListEntry,
isErrorResponse,
getErrorFromErrorResponse,
} from '@standardnotes/snjs'
import { FunctionComponent, useState, useEffect, useRef, useMemo } from 'react'
import { WebApplication } from '@/Application/WebApplication'
import { observer } from 'mobx-react-lite'
@@ -64,9 +71,10 @@ function useSessions(
if (!response) {
setSessions(sessionsBeforeRevoke)
} else if (isErrorResponse(response)) {
if (response.data?.error.message) {
setErrorMessage(response.data?.error.message || 'An unknown error occured while revoking the session.')
}
setErrorMessage(
getErrorFromErrorResponse(response).message || 'An unknown error occured while revoking the session.',
)
setSessions(sessionsBeforeRevoke)
} else {
setSessions(sessions.filter((session) => session.uuid !== uuid))