From 1717fbf5454d70f50cfb7b3e2edba256582dfdfe Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Thu, 17 Feb 2022 02:21:37 +0530 Subject: [PATCH] refactor: move setting allNotesCount_ into action (#877) --- app/assets/javascripts/ui_models/app_state/tags_state.ts | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/assets/javascripts/ui_models/app_state/tags_state.ts b/app/assets/javascripts/ui_models/app_state/tags_state.ts index 2add046b7..4825f180a 100644 --- a/app/assets/javascripts/ui_models/app_state/tags_state.ts +++ b/app/assets/javascripts/ui_models/app_state/tags_state.ts @@ -95,6 +95,7 @@ export class TagsState { hasAtLeastOneFolder: computed, allNotesCount_: observable, allNotesCount: computed, + setAllNotesCount: action, selected_: observable.ref, previouslySelected_: observable.ref, @@ -148,9 +149,7 @@ export class TagsState { appEventListeners.push( this.application.addNoteCountChangeObserver((tagUuid) => { if (!tagUuid) { - runInAction(() => { - this.allNotesCount_ = this.application.allCountableNotesCount(); - }); + this.setAllNotesCount(this.application.allCountableNotesCount()); } else { this.tagsCountsState.update([ this.application.findItem(tagUuid) as SNTag, @@ -238,6 +237,10 @@ export class TagsState { return this.tags.length; } + setAllNotesCount(allNotesCount: number) { + this.allNotesCount_ = allNotesCount; + } + public get allNotesCount(): number { return this.allNotesCount_; }