From 19243082e27e2d604142629897bc9fe9d65af840 Mon Sep 17 00:00:00 2001
From: Baptiste Grob <60621355+baptiste-grob@users.noreply.github.com>
Date: Mon, 26 Oct 2020 16:10:18 +0100
Subject: [PATCH] fix: user preferences

---
 app/assets/javascripts/services/preferencesManager.ts | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/app/assets/javascripts/services/preferencesManager.ts b/app/assets/javascripts/services/preferencesManager.ts
index 625458613..6b3b8f821 100644
--- a/app/assets/javascripts/services/preferencesManager.ts
+++ b/app/assets/javascripts/services/preferencesManager.ts
@@ -14,7 +14,7 @@ export class PreferencesManager extends ApplicationService {
   private userPreferences!: SNUserPrefs;
   private loadingPrefs = false;
   private unubscribeStreamItems?: () => void;
-  private shouldReloadSingleton = true;
+  private needsSingletonReload = true;
 
   /** @override */
   async onAppLaunch() {
@@ -24,6 +24,7 @@ export class PreferencesManager extends ApplicationService {
   }
 
   async onAppEvent(event: ApplicationEvent) {
+    super.onAppEvent(event);
     if (event === ApplicationEvent.CompletedFullSync) {
       this.reloadSingleton();
     }
@@ -41,13 +42,13 @@ export class PreferencesManager extends ApplicationService {
     this.unubscribeStreamItems = this.application!.streamItems(
       ContentType.UserPrefs,
       () => {
-        this.shouldReloadSingleton = true;
+        this.needsSingletonReload = true;
       }
     );
   }
 
   private async reloadSingleton() {
-    if (this.loadingPrefs || !this.shouldReloadSingleton) {
+    if (this.loadingPrefs || !this.needsSingletonReload) {
       return;
     }
     this.loadingPrefs = true;
@@ -60,6 +61,7 @@ export class PreferencesManager extends ApplicationService {
       FillItemContent({}),
     )) as SNUserPrefs;
     this.loadingPrefs = false;
+    this.needsSingletonReload = false;
     const didChange =
       !previousRef ||
       this.userPreferences.lastSyncBegan?.getTime() !==