rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: remove redundant check in template

Browse Source
This commit is contained in:
Mo Bitar
2021-12-02 13:07:28 -06:00
parent 9730006cba
commit 1a138ef83d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/assets/javascripts/components/ComponentView/index.tsx
View File

@@ -34,7 +34,6 @@ const avoidFlickerTimeout = 7;
export const ComponentView: FunctionalComponent<IProps> = observer( export const ComponentView: FunctionalComponent<IProps> = observer(
({ ({
application, application,
appState,
onLoad, onLoad,
componentUuid, componentUuid,
templateComponent templateComponent
@@ -194,6 +193,7 @@ export const ComponentView: FunctionalComponent<IProps> = observer(
useEffect(() => { useEffect(() => {
reloadStatus(); reloadStatus();
if (!iframeRef.current) { if (!iframeRef.current) {
return; return;
} }
@@ -250,7 +250,7 @@ export const ComponentView: FunctionalComponent<IProps> = observer(
onVisibilityChange onVisibilityChange
); );
}; };
}, [appState, application, component, componentUuid, onVisibilityChange, reloadStatus, templateComponent]); }, [application, component, componentUuid, onVisibilityChange, templateComponent]);
useEffect(() => { useEffect(() => {
// Set/update `component` based on `componentUuid` prop. // Set/update `component` based on `componentUuid` prop.

4
app/assets/javascripts/views/tags/tags-view.pug
View File

@@ -1,11 +1,11 @@
#tags-column.sn-component.section.tags(aria-label='Tags') #tags-column.sn-component.section.tags(aria-label='Tags')
.component-view-container(ng-if='self.component && self.component.active') .component-view-container(ng-if='self.component')
component-view.component-view( component-view.component-view(
component-uuid='self.component.uuid', component-uuid='self.component.uuid',
application='self.application' application='self.application'
app-state='self.appState' app-state='self.appState'
) )
#tags-content.content(ng-if='!(self.component && self.component.active)') #tags-content.content(ng-if='!(self.component)')
.tags-title-section.section-title-bar .tags-title-section.section-title-bar
.section-title-bar-header .section-title-bar-header
.sk-h3.title .sk-h3.title