rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Prompt for reauth in case of 498 drop (#2883)

Browse Source
This commit is contained in:
Mo
2024-09-09 09:51:51 -05:00
committed by GitHub
parent c11e14157f
commit 1cbf933fda
1 changed files with 11 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
packages/snjs/lib/Services/Api/ApiService.ts
View File

@@ -945,7 +945,17 @@ export class LegacyApiService
} }
private preprocessAuthenticatedErrorResponse(response: HttpResponse) { private preprocessAuthenticatedErrorResponse(response: HttpResponse) {
if (response.status === HttpStatusCode.Unauthorized && this.session) { if (!this.session) {
return
}
/**
* In most cases the ExpiredAccessToken erorr shouldn't reach this function, since if a 498 is caught, a refresh
* will automatically take place. However there does appear to be rare cases where for some reason the 498 falls through,
* perhaps because for example the server responds to a refresh request with a 498. In those cases, we'll just
* fallback here to the invalid session observer so that the user can be reprompted for auth.
*/
if (response.status === HttpStatusCode.Unauthorized || response.status === HttpStatusCode.ExpiredAccessToken) {
this.invalidSessionObserver?.(response.data.error?.tag === ErrorTag.RevokedSession) this.invalidSessionObserver?.(response.data.error?.tag === ErrorTag.RevokedSession)
} }
} }