From af1a369e632111e906c057e929f7b8d98408d154 Mon Sep 17 00:00:00 2001
From: Mo Bitar <me@bitar.io>
Date: Sat, 6 Mar 2021 11:25:12 -0600
Subject: [PATCH 1/3] fix: smart tag selection issue

---
 app/assets/javascripts/views/notes/notes_view.ts | 4 ++--
 app/assets/javascripts/views/tags/tags_view.ts   | 8 ++------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/app/assets/javascripts/views/notes/notes_view.ts b/app/assets/javascripts/views/notes/notes_view.ts
index 42340d9a9..5a8911252 100644
--- a/app/assets/javascripts/views/notes/notes_view.ts
+++ b/app/assets/javascripts/views/notes/notes_view.ts
@@ -328,7 +328,7 @@ class NotesViewCtrl extends PureViewCtrl<unknown, NotesState> {
    * an index is roughly O(n^2).
    */
   private reloadNotesDisplayOptions() {
-    const tag = this.appState.selectedTag!;
+    const tag = this.appState.selectedTag;
     const searchText = this.getState().noteFilter.text.toLowerCase();
     const searchQuery = searchText ? {
       query: searchText,
@@ -337,7 +337,7 @@ class NotesViewCtrl extends PureViewCtrl<unknown, NotesState> {
     const criteria = NotesDisplayCriteria.Create({
       sortProperty: this.state.sortBy! as CollectionSort,
       sortDirection: this.state.sortReverse! ? 'asc' : 'dsc',
-      tags: [tag],
+      tags: tag ? [tag] : [],
       includeArchived: this.getState().showArchived!,
       includePinned: !this.getState().hidePinned!,
       searchQuery: searchQuery
diff --git a/app/assets/javascripts/views/tags/tags_view.ts b/app/assets/javascripts/views/tags/tags_view.ts
index 60add087a..d7ce1bbc8 100644
--- a/app/assets/javascripts/views/tags/tags_view.ts
+++ b/app/assets/javascripts/views/tags/tags_view.ts
@@ -246,12 +246,8 @@ class TagsViewCtrl extends PureViewCtrl<unknown, TagState> {
               this.selectTag(tag as SNTag);
             }
           } else if (data.item!.content_type === ContentType.SmartTag) {
-            this.application.createTemplateItem(
-              ContentType.SmartTag,
-              data.item!.content as PayloadContent
-            ).then(smartTag => {
-              this.selectTag(smartTag as SNSmartTag);
-            });
+            const matchingTag = this.getState().smartTags.find(t => t.uuid === data.item!.uuid);
+            this.selectTag(matchingTag as SNSmartTag);
           }
         } else if (action === ComponentAction.ClearSelection) {
           this.selectTag(this.getState().smartTags[0]);

From f2e380f036e9295a0244d027b75dec17e5c4eb10 Mon Sep 17 00:00:00 2001
From: Baptiste Grob <60621355+baptiste-grob@users.noreply.github.com>
Date: Mon, 8 Mar 2021 10:03:56 +0100
Subject: [PATCH 2/3] fix: improve app version contrast

---
 app/assets/templates/directives/account-menu.pug | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/app/assets/templates/directives/account-menu.pug b/app/assets/templates/directives/account-menu.pug
index e56af6939..5826e5219 100644
--- a/app/assets/templates/directives/account-menu.pug
+++ b/app/assets/templates/directives/account-menu.pug
@@ -303,11 +303,11 @@
     .sk-panel-footer
       .sk-panel-row
         .sk-p.left.neutral
-          span.faded {{self.state.appVersion}}
+          span {{self.state.appVersion}}
           span(ng-if="self.state.showBetaWarning")
-            span.faded  (
+            span  (
             a.sk-a(ng-click="self.appState.disableBetaWarning()") Hide beta warning
-            span.faded )
+            span )
         a.sk-a.right(
           ng-click='self.hidePasswordForm()',
           ng-if='self.state.formData.showLogin || self.state.formData.showRegister'

From e1a5dde9687f8649e029c2cad03d8f709b3e2ac3 Mon Sep 17 00:00:00 2001
From: Baptiste Grob <60621355+baptiste-grob@users.noreply.github.com>
Date: Mon, 8 Mar 2021 10:05:20 +0100
Subject: [PATCH 3/3] fix: use neutral instead of subtle for text

---
 app/assets/templates/directives/account-menu.pug | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/assets/templates/directives/account-menu.pug b/app/assets/templates/directives/account-menu.pug
index 5826e5219..bde3c0f21 100644
--- a/app/assets/templates/directives/account-menu.pug
+++ b/app/assets/templates/directives/account-menu.pug
@@ -149,7 +149,7 @@
           .sk-panel-row
             .sk-panel-column
               .sk-h1.sk-bold.wrap {{self.state.user.email}}
-              .sk-subtitle.subtle.normal {{self.state.server}}
+              .sk-subtitle.neutral {{self.state.server}}
           .sk-panel-row
           a.sk-a.info.sk-panel-row.condensed(
             ng-click="self.openPasswordWizard()"