chore: vault tests refactors and lint (#2374)

packages/snjs/mocha/lib/Utils.js

@@ -11,15 +11,15 @@ export async function safeDeinit(application) {
   await application.storage.awaitPersist()
 
   /** Limit waiting to 1s */
-  await Promise.race([sleep(1), application.sync?.awaitCurrentSyncs()])
+  await Promise.race([sleep(1, 'Deinit'), application.sync?.awaitCurrentSyncs()])
 
   await application.prepareForDeinit()
 
   application.deinit(DeinitMode.Soft, DeinitSource.SignOut)
 }
 
-export async function sleep(seconds) {
-  console.warn(`Test sleeping for ${seconds}s`)
+export async function sleep(seconds, reason) {
+  console.warn(`Test sleeping for ${seconds}s. Reason: ${reason}`)
 
   return new Promise((resolve, reject) => {
     setTimeout(function () {
@@ -32,3 +32,22 @@ export function generateUuid() {
   const crypto = new FakeWebCrypto()
   return crypto.generateUUID()
 }
+
+export async function awaitPromiseOrThrow(promise, maxWait, reason) {
+  let timer = undefined
+
+  // Create a promise that rejects in <maxWait> milliseconds
+  const timeout = new Promise((resolve, reject) => {
+    timer = setTimeout(() => {
+      clearTimeout(timer)
+      console.error(reason)
+      reject(new Error(reason || `Promise timed out after ${maxWait} milliseconds: ${reason}`))
+    }, maxWait * 1000)
+  })
+
+  // Returns a race between our timeout and the passed in promise
+  return Promise.race([promise, timeout]).then((result) => {
+    clearTimeout(timer)
+    return result
+  })
+}