From 2b40ccfe132731920f8d80c3f129cbd7b6ae53e6 Mon Sep 17 00:00:00 2001
From: Antonella Sgarlatta <antonella@standardnotes.org>
Date: Thu, 3 Jun 2021 17:45:43 -0300
Subject: [PATCH] refactor: store refs in components

---
 .../components/AutocompleteTagInput.tsx       |  49 +++---
 .../components/AutocompleteTagResult.tsx      |  39 +++--
 app/assets/javascripts/components/NoteTag.tsx |  31 +++-
 .../ui_models/app_state/note_tags_state.ts    | 141 ++++++++----------
 4 files changed, 139 insertions(+), 121 deletions(-)

diff --git a/app/assets/javascripts/components/AutocompleteTagInput.tsx b/app/assets/javascripts/components/AutocompleteTagInput.tsx
index a4a57e49b..5756301da 100644
--- a/app/assets/javascripts/components/AutocompleteTagInput.tsx
+++ b/app/assets/javascripts/components/AutocompleteTagInput.tsx
@@ -12,12 +12,10 @@ type Props = {
 
 export const AutocompleteTagInput = observer(({ appState }: Props) => {
   const {
+    autocompleteInputFocused,
     autocompleteSearchQuery,
     autocompleteTagHintVisible,
     autocompleteTagResults,
-    autocompleteTagResultElements,
-    autocompleteInputElement,
-    tagElements,
     tags,
   } = appState.noteTags;
 
@@ -26,6 +24,7 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
     useState<number | 'auto'>('auto');
 
   const dropdownRef = useRef<HTMLDivElement>();
+  const inputRef = useRef<HTMLInputElement>();
 
   const [closeOnBlur] = useCloseOnBlur(dropdownRef, (visible: boolean) => {
     setDropdownVisible(visible);
@@ -33,11 +32,9 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
   });
 
   const showDropdown = () => {
-    if (autocompleteInputElement) {
-      const { clientHeight } = document.documentElement;
-      const inputRect = autocompleteInputElement.getBoundingClientRect();
-      setDropdownMaxHeight(clientHeight - inputRect.bottom - 32 * 2);
-    }
+    const { clientHeight } = document.documentElement;
+    const inputRect = inputRef.current.getBoundingClientRect();
+    setDropdownMaxHeight(clientHeight - inputRect.bottom - 32 * 2);
     setDropdownVisible(true);
   };
 
@@ -55,14 +52,15 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
   const onKeyDown = (event: KeyboardEvent) => {
     switch (event.key) {
       case 'Backspace':
-        if (autocompleteSearchQuery === '' && tagElements.length > 0) {
-          tagElements[tagElements.length - 1]?.focus();
+      case 'ArrowLeft':
+        if (autocompleteSearchQuery === '' && tags.length > 0) {
+          appState.noteTags.setFocusedTagUuid(tags[tags.length - 1].uuid);
         }
         break;
       case 'ArrowDown':
         event.preventDefault();
-        if (autocompleteTagResultElements.length > 0) {
-          autocompleteTagResultElements[0]?.focus();
+        if (autocompleteTagResults.length > 0) {
+          appState.noteTags.setFocusedTagResultUuid(autocompleteTagResults[0].uuid);
         }
         break;
       default:
@@ -70,10 +68,27 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
     }
   };
 
+  const onFocus = () => {
+    showDropdown();
+    appState.noteTags.setAutocompleteInputFocused(true);
+  };
+
+  const onBlur = (event: FocusEvent) => {
+    closeOnBlur(event);
+    appState.noteTags.setAutocompleteInputFocused(false);
+  };
+
   useEffect(() => {
     appState.noteTags.searchActiveNoteAutocompleteTags();
   }, [appState.noteTags]);
 
+  useEffect(() => {
+    if (autocompleteInputFocused) {
+      inputRef.current.focus();
+      appState.noteTags.setAutocompleteInputFocused(false);
+    }
+  }, [appState.noteTags, autocompleteInputFocused]);
+
   return (
     <form
       onSubmit={onFormSubmit}
@@ -81,18 +96,14 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
     >
       <Disclosure open={dropdownVisible} onChange={showDropdown}>
         <input
-          ref={(element) => {
-            if (element) {
-              appState.noteTags.setAutocompleteInputElement(element);
-            }
-          }}
+          ref={inputRef}
           className="w-80 bg-default text-xs color-text no-border h-7 focus:outline-none focus:shadow-none focus:border-bottom"
           value={autocompleteSearchQuery}
           onChange={onSearchQueryChange}
           type="text"
           placeholder="Add tag"
-          onBlur={closeOnBlur}
-          onFocus={showDropdown}
+          onBlur={onBlur}
+          onFocus={onFocus}
           onKeyDown={onKeyDown}
         />
         {dropdownVisible && (
diff --git a/app/assets/javascripts/components/AutocompleteTagResult.tsx b/app/assets/javascripts/components/AutocompleteTagResult.tsx
index 4dd36aab0..6a82555ac 100644
--- a/app/assets/javascripts/components/AutocompleteTagResult.tsx
+++ b/app/assets/javascripts/components/AutocompleteTagResult.tsx
@@ -1,6 +1,7 @@
 import { AppState } from '@/ui_models/app_state';
 import { SNTag } from '@standardnotes/snjs';
 import { observer } from 'mobx-react-lite';
+import { useEffect, useRef } from 'preact/hooks';
 import { Icon } from './Icon';
 
 type Props = {
@@ -11,7 +12,9 @@ type Props = {
 
 export const AutocompleteTagResult = observer(
   ({ appState, tagResult, closeOnBlur }: Props) => {
-    const { autocompleteInputElement, autocompleteSearchQuery, autocompleteTagResults } = appState.noteTags;
+    const { autocompleteSearchQuery, autocompleteTagResults, focusedTagResultUuid } = appState.noteTags;
+
+    const tagResultRef = useRef<HTMLButtonElement>();
 
     const onTagOptionClick = async (tag: SNTag) => {
       await appState.noteTags.addTagToActiveNote(tag);
@@ -24,34 +27,44 @@ export const AutocompleteTagResult = observer(
         case 'ArrowUp':
           event.preventDefault();
           if (tagResultIndex === 0) {
-            autocompleteInputElement?.focus();
+            appState.noteTags.setAutocompleteInputFocused(true);
           } else {
-            appState.noteTags.getPreviousAutocompleteTagResultElement(tagResult)?.focus();
+            appState.noteTags.focusPreviousTagResult(tagResult);
           }
           break;
         case 'ArrowDown':
           event.preventDefault();
-          appState.noteTags.getNextAutocompleteTagResultElement(tagResult)?.focus();
+          appState.noteTags.focusNextTagResult(tagResult);
           break;
         default:
           return;
       }
     };
 
+    const onFocus = () => {
+      appState.noteTags.setFocusedTagResultUuid(tagResult.uuid);
+    };
+
+    const onBlur = (event: FocusEvent) => {
+      closeOnBlur(event);
+      appState.noteTags.setFocusedTagResultUuid(undefined);
+    };
+
+    useEffect(() => {
+      if (focusedTagResultUuid === tagResult.uuid) {
+        tagResultRef.current.focus();
+        appState.noteTags.setFocusedTagResultUuid(undefined);
+      }
+    }, [appState.noteTags, focusedTagResultUuid, tagResult]);
+
     return (
       <button
-        ref={(element) => {
-          if (element) {
-            appState.noteTags.setAutocompleteTagResultElement(
-              tagResult,
-              element
-            );
-          }
-        }}
+        ref={tagResultRef}
         type="button"
         className="sn-dropdown-item"
         onClick={() => onTagOptionClick(tagResult)}
-        onBlur={closeOnBlur}
+        onFocus={onFocus}
+        onBlur={onBlur}
         onKeyDown={onKeyDown}
       >
         <Icon type="hashtag" className="color-neutral mr-2 min-h-5 min-w-5" />
diff --git a/app/assets/javascripts/components/NoteTag.tsx b/app/assets/javascripts/components/NoteTag.tsx
index f078c8a06..3afcc3d35 100644
--- a/app/assets/javascripts/components/NoteTag.tsx
+++ b/app/assets/javascripts/components/NoteTag.tsx
@@ -1,5 +1,5 @@
 import { Icon } from './Icon';
-import { useRef, useState } from 'preact/hooks';
+import { useEffect, useRef, useState } from 'preact/hooks';
 import { AppState } from '@/ui_models/app_state';
 import { SNTag } from '@standardnotes/snjs/dist/@types';
 import { observer } from 'mobx-react-lite';
@@ -10,11 +10,16 @@ type Props = {
 };
 
 export const NoteTag = observer(({ appState, tag }: Props) => {
+  const { focusedTagUuid, tags } = appState.noteTags;
+
   const [showDeleteButton, setShowDeleteButton] = useState(false);
   const [tagClicked, setTagClicked] = useState(false);
   const deleteTagRef = useRef<HTMLButtonElement>();
 
+  const tagRef = useRef<HTMLButtonElement>();
+
   const deleteTag = () => {
+    appState.noteTags.focusPreviousTag(tag);
     appState.noteTags.removeTagFromActiveNote(tag);
   };
 
@@ -34,39 +39,49 @@ export const NoteTag = observer(({ appState, tag }: Props) => {
   };
 
   const onFocus = () => {
+    appState.noteTags.setFocusedTagUuid(tag.uuid);
     setShowDeleteButton(true);
   };
 
   const onBlur = (event: FocusEvent) => {
     const relatedTarget = event.relatedTarget as Node;
     if (relatedTarget !== deleteTagRef.current) {
+      appState.noteTags.setFocusedTagUuid(undefined);
       setShowDeleteButton(false);
     }
   };
 
   const onKeyDown = (event: KeyboardEvent) => {
+    const tagIndex = appState.noteTags.getTagIndex(tag, tags);
     switch (event.key) {
       case 'Backspace':
         deleteTag();
         break;
       case 'ArrowLeft':
-        appState.noteTags.getPreviousTagElement(tag)?.focus();
+        appState.noteTags.focusPreviousTag(tag);
         break;
       case 'ArrowRight':
-        appState.noteTags.getNextTagElement(tag)?.focus();
+        if (tagIndex === tags.length - 1) {
+          appState.noteTags.setAutocompleteInputFocused(true);
+        } else {
+          appState.noteTags.focusNextTag(tag);
+        }
         break;
       default:
         return;
     }
   };
 
+  useEffect(() => {
+    if (focusedTagUuid === tag.uuid) {
+      tagRef.current.focus();
+      appState.noteTags.setFocusedTagUuid(undefined);
+    }
+  }, [appState.noteTags, focusedTagUuid, tag]);
+
   return (
     <button
-      ref={(element) => {
-        if (element) {
-          appState.noteTags.setTagElement(tag, element);
-        }
-      }}
+      ref={tagRef}
       className="sn-tag pl-1 pr-2 mr-2"
       onClick={onTagClick}
       onKeyDown={onKeyDown}
diff --git a/app/assets/javascripts/ui_models/app_state/note_tags_state.ts b/app/assets/javascripts/ui_models/app_state/note_tags_state.ts
index 0142f2338..355bdc87c 100644
--- a/app/assets/javascripts/ui_models/app_state/note_tags_state.ts
+++ b/app/assets/javascripts/ui_models/app_state/note_tags_state.ts
@@ -1,14 +1,14 @@
-import { SNNote, ContentType, SNTag } from '@standardnotes/snjs';
+import { SNNote, ContentType, SNTag, UuidString } from '@standardnotes/snjs';
 import { action, computed, makeObservable, observable } from 'mobx';
 import { WebApplication } from '../application';
 import { AppState } from './app_state';
 
 export class NoteTagsState {
-  autocompleteInputElement: HTMLInputElement | undefined = undefined;
+  autocompleteInputFocused = false;
   autocompleteSearchQuery = '';
-  autocompleteTagResultElements: (HTMLButtonElement | undefined)[] = [];
   autocompleteTagResults: SNTag[] = [];
-  tagElements: (HTMLButtonElement | undefined)[] = [];
+  focusedTagResultUuid: UuidString | undefined = undefined;
+  focusedTagUuid: UuidString | undefined = undefined;
   tags: SNTag[] = [];
   tagsContainerMaxWidth: number | 'auto' = 0;
 
@@ -18,24 +18,24 @@ export class NoteTagsState {
     appEventListeners: (() => void)[]
   ) {
     makeObservable(this, {
-      autocompleteInputElement: observable,
+      autocompleteInputFocused: observable,
       autocompleteSearchQuery: observable,
-      autocompleteTagResultElements: observable,
       autocompleteTagResults: observable,
-      tagElements: observable,
+      focusedTagUuid: observable,
+      focusedTagResultUuid: observable,
       tags: observable,
       tagsContainerMaxWidth: observable,
 
       autocompleteTagHintVisible: computed,
 
       clearAutocompleteSearch: action,
-      setAutocompleteInputElement: action,
+      focusNextTag: action,
+      focusPreviousTag: action,
+      setAutocompleteInputFocused: action,
       setAutocompleteSearchQuery: action,
-      setAutocompleteTagResultElement: action,
-      setAutocompleteTagResultElements: action,
       setAutocompleteTagResults: action,
-      setTagElement: action,
-      setTagElements: action,
+      setFocusedTagResultUuid: action,
+      setFocusedTagUuid: action,
       setTags: action,
       setTagsContainerMaxWidth: action,
       reloadTags: action,
@@ -61,43 +61,25 @@ export class NoteTagsState {
     );
   }
 
-  setAutocompleteInputElement(element: HTMLInputElement | undefined): void {
-    this.autocompleteInputElement = element;
+  setAutocompleteInputFocused(focused: boolean): void {
+    console.log('set focused', focused);
+    this.autocompleteInputFocused = focused;
   }
 
   setAutocompleteSearchQuery(query: string): void {
     this.autocompleteSearchQuery = query;
   }
 
-  setAutocompleteTagResultElement(
-    tagResult: SNTag,
-    element: HTMLButtonElement
-  ): void {
-    const tagIndex = this.getTagIndex(tagResult, this.autocompleteTagResults);
-    if (tagIndex > -1) {
-      this.autocompleteTagResultElements.splice(tagIndex, 1, element);
-    }
-  }
-
-  setAutocompleteTagResultElements(
-    elements: (HTMLButtonElement | undefined)[]
-  ): void {
-    this.autocompleteTagResultElements = elements;
-  }
-
   setAutocompleteTagResults(results: SNTag[]): void {
     this.autocompleteTagResults = results;
   }
 
-  setTagElement(tag: SNTag, element: HTMLButtonElement): void {
-    const tagIndex = this.getTagIndex(tag, this.tags);
-    if (tagIndex > -1) {
-      this.tagElements.splice(tagIndex, 1, element);
-    }
+  setFocusedTagUuid(tagUuid: UuidString | undefined): void {
+    this.focusedTagUuid = tagUuid;
   }
 
-  setTagElements(elements: (HTMLButtonElement | undefined)[]): void {
-    this.tagElements = elements;
+  setFocusedTagResultUuid(tagUuid: UuidString | undefined): void {
+    this.focusedTagResultUuid = tagUuid;
   }
 
   setTags(tags: SNTag[]): void {
@@ -121,6 +103,47 @@ export class NoteTagsState {
     this.clearAutocompleteSearch();
   }
 
+  focusNextTag(tag: SNTag): void {
+    const nextTagIndex = this.getTagIndex(tag, this.tags) + 1;
+    if (nextTagIndex > -1 && this.tags.length > nextTagIndex) {
+      const nextTag = this.tags[nextTagIndex];
+      this.setFocusedTagUuid(nextTag.uuid);
+    }
+  }
+
+  focusNextTagResult(tagResult: SNTag): void {
+    const nextTagResultIndex =
+      this.getTagIndex(tagResult, this.autocompleteTagResults) + 1;
+    if (
+      nextTagResultIndex > -1 &&
+      this.autocompleteTagResults.length > nextTagResultIndex
+    ) {
+      const nextTagResult = this.autocompleteTagResults[nextTagResultIndex];
+      this.setFocusedTagResultUuid(nextTagResult.uuid);
+    }
+  }
+
+  focusPreviousTag(tag: SNTag): void {
+    const previousTagIndex = this.getTagIndex(tag, this.tags) - 1;
+    if (previousTagIndex > -1 && this.tags.length > previousTagIndex) {
+      const previousTag = this.tags[previousTagIndex];
+      this.setFocusedTagUuid(previousTag.uuid);
+    }
+  }
+
+  focusPreviousTagResult(tagResult: SNTag): void {
+    const previousTagResultIndex =
+      this.getTagIndex(tagResult, this.autocompleteTagResults) - 1;
+    if (
+      previousTagResultIndex > -1 &&
+      this.autocompleteTagResults.length > previousTagResultIndex
+    ) {
+      const previousTagResult =
+        this.autocompleteTagResults[previousTagResultIndex];
+      this.setFocusedTagResultUuid(previousTagResult.uuid);
+    }
+  }
+
   searchActiveNoteAutocompleteTags(): void {
     const newResults = this.application.searchTags(
       this.autocompleteSearchQuery,
@@ -133,53 +156,11 @@ export class NoteTagsState {
     return tagsArr.findIndex((t) => t.uuid === tag.uuid);
   }
 
-  getPreviousTagElement(tag: SNTag): HTMLButtonElement | undefined {
-    const previousTagIndex = this.getTagIndex(tag, this.tags) - 1;
-    if (previousTagIndex > -1 && this.tagElements.length > previousTagIndex) {
-      return this.tagElements[previousTagIndex];
-    }
-  }
-
-  getNextTagElement(tag: SNTag): HTMLButtonElement | undefined {
-    const nextTagIndex = this.getTagIndex(tag, this.tags) + 1;
-    if (nextTagIndex > -1 && this.tagElements.length > nextTagIndex) {
-      return this.tagElements[nextTagIndex];
-    }
-  }
-
-  getPreviousAutocompleteTagResultElement(
-    tagResult: SNTag
-  ): HTMLButtonElement | undefined {
-    const previousTagIndex =
-      this.getTagIndex(tagResult, this.autocompleteTagResults) - 1;
-    if (
-      previousTagIndex > -1 &&
-      this.autocompleteTagResultElements.length > previousTagIndex
-    ) {
-      return this.autocompleteTagResultElements[previousTagIndex];
-    }
-  }
-
-  getNextAutocompleteTagResultElement(
-    tagResult: SNTag
-  ): HTMLButtonElement | undefined {
-    const nextTagIndex =
-      this.getTagIndex(tagResult, this.autocompleteTagResults) + 1;
-    if (
-      nextTagIndex > -1 &&
-      this.autocompleteTagResultElements.length > nextTagIndex
-    ) {
-      return this.autocompleteTagResultElements[nextTagIndex];
-    }
-  }
-
   reloadTags(): void {
     const { activeNote } = this;
     if (activeNote) {
       const tags = this.application.getSortedTagsForNote(activeNote);
-      const tagElements: (HTMLButtonElement | undefined)[] = [];
       this.setTags(tags);
-      this.setTagElements(tagElements.fill(undefined, tags.length));
     }
   }
 
@@ -205,12 +186,10 @@ export class NoteTagsState {
   async removeTagFromActiveNote(tag: SNTag): Promise<void> {
     const { activeNote } = this;
     if (activeNote) {
-      const previousTagElement = this.getPreviousTagElement(tag);
       await this.application.changeItem(tag.uuid, (mutator) => {
         mutator.removeItemAsRelationship(activeNote);
       });
       this.application.sync();
-      previousTagElement?.focus();
       this.reloadTags();
     }
   }