refactor: component manager usecases (#2354)

packages/web/src/javascripts/Application/WebApplication.spec.ts

@@ -1,24 +1,9 @@
-/**
- * @jest-environment jsdom
- */
-
-import {
-  Environment,
-  FeatureIdentifier,
-  namespacedKey,
-  Platform,
-  RawStorageKey,
-  SNComponent,
-  SNComponentManager,
-  SNLog,
-  SNTag,
-} from '@standardnotes/snjs'
+import { Environment, namespacedKey, Platform, RawStorageKey, SNLog } from '@standardnotes/snjs'
 import { WebApplication } from '@/Application/WebApplication'
 import { WebOrDesktopDevice } from './Device/WebOrDesktopDevice'
 
 describe('web application', () => {
   let application: WebApplication
-  let componentManager: SNComponentManager
 
   // eslint-disable-next-line no-console
   SNLog.onLog = console.log
@@ -45,51 +30,10 @@ describe('web application', () => {
 
     application = new WebApplication(device, Platform.MacWeb, identifier, 'https://sync', 'https://socket')
 
-    componentManager = {} as jest.Mocked<SNComponentManager>
-    componentManager.legacyGetDefaultEditor = jest.fn()
-    Object.defineProperty(application, 'componentManager', { value: componentManager })
-
     await application.prepareForLaunch({ receiveChallenge: jest.fn() })
   })
 
-  describe('geDefaultEditorIdentifier', () => {
-    it('should return plain editor if no default tag editor or component editor', () => {
-      const editorIdentifier = application.geDefaultEditorIdentifier()
-
-      expect(editorIdentifier).toEqual(FeatureIdentifier.PlainEditor)
-    })
-
-    it('should return pref key based value if available', () => {
-      application.getPreference = jest.fn().mockReturnValue(FeatureIdentifier.SuperEditor)
-
-      const editorIdentifier = application.geDefaultEditorIdentifier()
-
-      expect(editorIdentifier).toEqual(FeatureIdentifier.SuperEditor)
-    })
-
-    it('should return default tag identifier if tag supplied', () => {
-      const tag = {
-        preferences: {
-          editorIdentifier: FeatureIdentifier.SuperEditor,
-        },
-      } as jest.Mocked<SNTag>
-
-      const editorIdentifier = application.geDefaultEditorIdentifier(tag)
-
-      expect(editorIdentifier).toEqual(FeatureIdentifier.SuperEditor)
-    })
-
-    it('should return legacy editor identifier', () => {
-      const editor = {
-        legacyIsDefaultEditor: jest.fn().mockReturnValue(true),
-        identifier: FeatureIdentifier.MarkdownProEditor,
-      } as unknown as jest.Mocked<SNComponent>
-
-      componentManager.legacyGetDefaultEditor = jest.fn().mockReturnValue(editor)
-
-      const editorIdentifier = application.geDefaultEditorIdentifier()
-
-      expect(editorIdentifier).toEqual(FeatureIdentifier.MarkdownProEditor)
-    })
+  it('should create application', () => {
+    expect(application).toBeTruthy()
   })
 })

packages/web/src/javascripts/Application/WebApplication.ts

@@ -17,8 +17,6 @@ import {
   MobileDeviceInterface,
   MobileUnlockTiming,
   DecryptedItem,
-  EditorIdentifier,
-  FeatureIdentifier,
   Environment,
   ApplicationOptionsDefaults,
   BackupServiceInterface,
@@ -511,15 +509,6 @@ export class WebApplication extends SNApplication implements WebApplicationInter
     return this.environment === Environment.Web
   }
 
-  geDefaultEditorIdentifier(currentTag?: SNTag): EditorIdentifier {
-    return (
-      currentTag?.preferences?.editorIdentifier ||
-      this.getPreference(PrefKey.DefaultEditorIdentifier) ||
-      this.componentManager.legacyGetDefaultEditor()?.identifier ||
-      FeatureIdentifier.PlainEditor
-    )
-  }
-
   openPreferences(pane?: PreferenceId): void {
     this.controllers.preferencesController.openPreferences()
     if (pane) {