From 31a1d112aca53140cfddc8ed090595ec48f5844e Mon Sep 17 00:00:00 2001 From: Johnny Almonte Date: Sat, 27 Jun 2020 22:40:29 -0400 Subject: [PATCH] refactor: loadExtensions method --- app/assets/javascripts/directives/views/actionsMenu.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/assets/javascripts/directives/views/actionsMenu.ts b/app/assets/javascripts/directives/views/actionsMenu.ts index 3d7ee80b5..a38321c30 100644 --- a/app/assets/javascripts/directives/views/actionsMenu.ts +++ b/app/assets/javascripts/directives/views/actionsMenu.ts @@ -56,15 +56,13 @@ class ActionsMenuCtrl extends PureViewCtrl implements ActionsMenuScope { const actionExtensions = this.application.actionsManager!.getExtensions().sort((a, b) => { return a.name.toLowerCase() < b.name.toLowerCase() ? -1 : 1; }); - let extensionsForItem = []; - for (const extension of actionExtensions) { - const extensionInContext = await this.application.actionsManager!.loadExtensionInContextOfItem( + const extensionsForItem = await Promise.all(actionExtensions.map((extension) => { + return this.application.actionsManager!.loadExtensionInContextOfItem( extension, this.props.item ); - extensionsForItem.push(extensionInContext); - } - if (actionExtensions.length == 0) { + })); + if (extensionsForItem.length == 0) { this.loadingExtensions = false; } await this.setState({