From 337c6532d17959c52287adc82cd4354f95852eb6 Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Tue, 12 Dec 2023 19:04:44 +0530
Subject: [PATCH] chore: fix plaintext icon color on hover in selection
 dropdown

---
 .../src/javascripts/Components/Dropdown/Dropdown.tsx  |  2 +-
 .../src/javascripts/Utils/DropdownItemsForEditors.ts  | 11 ++++++++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/packages/web/src/javascripts/Components/Dropdown/Dropdown.tsx b/packages/web/src/javascripts/Components/Dropdown/Dropdown.tsx
index e22766c8c..355ed76ba 100644
--- a/packages/web/src/javascripts/Components/Dropdown/Dropdown.tsx
+++ b/packages/web/src/javascripts/Components/Dropdown/Dropdown.tsx
@@ -84,7 +84,7 @@ const Dropdown = ({
       >
         {items.map((item) => (
           <SelectItem
-            className="flex cursor-pointer items-center bg-transparent px-3 py-1.5 text-sm text-text hover:bg-contrast hover:text-foreground [&[data-active-item]]:bg-info [&[data-active-item]]:text-info-contrast"
+            className="group flex cursor-pointer items-center bg-transparent px-3 py-1.5 text-sm text-text hover:bg-contrast hover:text-foreground [&[data-active-item]]:bg-info [&[data-active-item]]:text-info-contrast"
             key={item.value}
             value={item.value}
             disabled={item.disabled}
diff --git a/packages/web/src/javascripts/Utils/DropdownItemsForEditors.ts b/packages/web/src/javascripts/Utils/DropdownItemsForEditors.ts
index 073dfa39b..985858273 100644
--- a/packages/web/src/javascripts/Utils/DropdownItemsForEditors.ts
+++ b/packages/web/src/javascripts/Utils/DropdownItemsForEditors.ts
@@ -3,10 +3,12 @@ import {
   FindNativeFeature,
   GetIframeAndNativeEditors,
   NativeFeatureIdentifier,
+  NoteType,
 } from '@standardnotes/features'
 import { getIconAndTintForNoteType } from './Items/Icons/getIconAndTintForNoteType'
 import { DropdownItem } from '@/Components/Dropdown/DropdownItem'
 import { WebApplicationInterface } from '@standardnotes/ui-services'
+import { classNames } from '@standardnotes/snjs'
 
 export type EditorOption = DropdownItem & {
   value: string
@@ -25,7 +27,14 @@ export function getDropdownItemsForAllEditors(application: WebApplicationInterfa
         value: editor.identifier,
         id: NativeFeatureIdentifier.create(editor.identifier).getValue(),
         ...(iconType ? { icon: iconType } : null),
-        ...(tint ? { iconClassName: `text-accessory-tint-${tint}` } : null),
+        ...(tint
+          ? {
+              iconClassName: classNames(
+                `text-accessory-tint-${tint}`,
+                editor.note_type === NoteType.Plain && 'group-hover:text-info-contrast',
+              ),
+            }
+          : null),
       }
     }),
   )