fix: Fixed issue where Super note would convert whole line into tag even after closing menu

This commit is contained in:
Aman Harwara
2022-12-23 15:03:18 +05:30
parent f3e147f4c9
commit 35b00737bf
6 changed files with 7 additions and 31 deletions

View File

@@ -75,7 +75,7 @@ const Popover = ({
if (open) {
removeListener = addAndroidBackHandler(() => {
togglePopover()
togglePopover?.()
return true
})
}

View File

@@ -90,7 +90,7 @@ const PositionedPopoverContent = ({
onKeyDown={(event) => {
if (event.key === 'Escape') {
event.stopPropagation()
togglePopover()
togglePopover?.()
if (anchorElement) {
anchorElement.focus()
}

View File

@@ -35,7 +35,7 @@ type CommonPopoverProps = {
children: ReactNode
side?: PopoverSide
overrideZIndex?: string
togglePopover: () => void
togglePopover?: () => void
className?: string
disableClickOutside?: boolean
disableMobileFullscreenTakeover?: boolean

View File

@@ -4,7 +4,7 @@ import { useEffect } from 'react'
type Options = {
popoverElement: HTMLElement | null
anchorElement: HTMLElement | null | undefined
togglePopover: () => void
togglePopover?: () => void
childPopovers: Set<string>
disabled?: boolean
}
@@ -34,7 +34,7 @@ export const usePopoverCloseOnClickOutside = ({
if (!isDescendantOfMenu && !isAnchorElement && !isDescendantOfChildPopover && !isDescendantOfChallengeModal) {
if (!disabled) {
togglePopover()
togglePopover?.()
}
}
}