rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't sync components if just activating/deactivating on a local level

Browse Source
This commit is contained in:
Mo Bitar
2018-04-15 10:43:19 -05:00
parent 75af353e8b
commit 36ce04a0e6
1 changed files with 15 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/assets/javascripts/app/directives/views/componentView.js
View File

@@ -53,14 +53,25 @@ class ComponentView {
controller($scope, $rootScope, $timeout, componentManager, desktopManager) { controller($scope, $rootScope, $timeout, componentManager, desktopManager) {
'ngInject'; 'ngInject';
/*
General note regarding activation/deactivation of components:
We pass `true` to componentManager.ac/detivateComponent for the `dontSync` parameter.
The activation we do in here is not global, but just local, so we don't need to sync the state.
For example, if we activate an editor, we just need to do that for display purposes, but dont
need to perform a sync to propagate that .active flag.
*/
this.componentValueChanging = (component, prevComponent) => { this.componentValueChanging = (component, prevComponent) => {
//
// See comment above about passing true to componentManager.ac/detivateComponent
//
if(prevComponent && component !== prevComponent) { if(prevComponent && component !== prevComponent) {
// Deactive old component // Deactive old component
componentManager.deactivateComponent(prevComponent); componentManager.deactivateComponent(prevComponent, true);
} }
if(component) { if(component) {
componentManager.activateComponent(component); componentManager.activateComponent(component, true);
console.log("Loading", $scope.component.name, $scope.getUrl(), component.valid_until); console.log("Loading", $scope.component.name, $scope.getUrl(), component.valid_until);
$scope.reloadStatus(); $scope.reloadStatus();
@@ -101,7 +112,7 @@ class ComponentView {
if($scope.componentValid !== previouslyValid) { if($scope.componentValid !== previouslyValid) {
if($scope.componentValid) { if($scope.componentValid) {
componentManager.activateComponent(component); componentManager.activateComponent(component, true);
} }
} }
@@ -126,7 +137,7 @@ class ComponentView {
// console.log("Deregistering handler", $scope.identifier, $scope.component.name); // console.log("Deregistering handler", $scope.identifier, $scope.component.name);
componentManager.deregisterHandler($scope.identifier); componentManager.deregisterHandler($scope.identifier);
if($scope.component && !$scope.manualDealloc) { if($scope.component && !$scope.manualDealloc) {
componentManager.deactivateComponent($scope.component); componentManager.deactivateComponent($scope.component, true);
} }
desktopManager.deregisterUpdateObserver($scope.updateObserver); desktopManager.deregisterUpdateObserver($scope.updateObserver);