From 372991a8a038ab8f06901d6e592341cf01c93eb7 Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Mon, 24 Apr 2023 22:00:11 +0530 Subject: [PATCH] chore: fix ios review --- packages/mobile/ios/Podfile.lock | 4 +-- packages/mobile/ios/Red.png | Bin 388 -> 0 bytes packages/mobile/ios/Red@2x.png | Bin 651 -> 0 bytes packages/mobile/ios/Red@3x.png | Bin 877 -> 0 bytes .../StandardNotes.xcodeproj/project.pbxproj | 22 ++-------------- packages/mobile/ios/StandardNotes/Info.plist | 24 ------------------ .../mobile/ios/StandardNotesDev-Info.plist | 12 --------- packages/web/package.json | 2 +- 8 files changed, 5 insertions(+), 59 deletions(-) delete mode 100644 packages/mobile/ios/Red.png delete mode 100644 packages/mobile/ios/Red@2x.png delete mode 100644 packages/mobile/ios/Red@3x.png diff --git a/packages/mobile/ios/Podfile.lock b/packages/mobile/ios/Podfile.lock index a3217a32a..ac3cd08b2 100644 --- a/packages/mobile/ios/Podfile.lock +++ b/packages/mobile/ios/Podfile.lock @@ -637,7 +637,7 @@ EXTERNAL SOURCES: :path: "../node_modules/react-native/ReactCommon/yoga" SPEC CHECKSUMS: - boost: a7c83b31436843459a1961bfd74b96033dc77234 + boost: 57d2868c099736d80fcd648bf211b4431e51a558 CocoaAsyncSocket: 065fd1e645c7abab64f7a6a2007a48038fdc6a99 DoubleConversion: 5189b271737e1565bdce30deb4a08d647e3f5f54 FBLazyVector: 60195509584153283780abdac5569feffb8f08cc @@ -658,7 +658,7 @@ SPEC CHECKSUMS: MMKV: 9c4663aa7ca255d478ff10f2f5cb7d17c1651ccd MMKVCore: 89f5c8a66bba2dcd551779dea4d412eeec8ff5bb OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c - RCT-Folly: 0080d0a6ebf2577475bda044aa59e2ca1f909cda + RCT-Folly: 424b8c9a7a0b9ab2886ffe9c3b041ef628fd4fb1 RCTRequired: bec48f07daf7bcdc2655a0cde84e07d24d2a9e2a RCTTypeSafety: 171394eebacf71e1cfad79dbfae7ee8fc16ca80a React: d7433ccb6a8c36e4cbed59a73c0700fc83c3e98a diff --git a/packages/mobile/ios/Red.png b/packages/mobile/ios/Red.png deleted file mode 100644 index 861f58998597489ee05f6f8ed621d319cff63ca5..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 388 zcmV-~0ek+5P)9_mW8DSIdk05o<{uL@h+OAdue z;_-Nt%8~`GB7L>A&S6RK`(AY{kwoA3SsSO?w6<-__G4$cVnW<{EL9P<*3;Cnlu{~{ zr3lT9C3Tms*|aoBqU*X-@2JAlH2o{om4py5j^n9!Zr!Cdp2_B$)?cihu-c{X-o(#J zzw`+|L-i{j5kZXc@E$5B)i3cx1j8`gLm04E($&XO>87Zj@YSV8vS<}G_wi7@q)X$% i)^TC$xUh9x*g8LxI%7i|ZEo8D0000$KIEGZrd3(pVXtsk0!$WiC z2=mU>MPlLa=FeeiJo4FVrOu{H89ZBl-`;Jrf|bX9aZ&aEnLnSGyT~dVIWsJE$=R-9 ze{b=cK%-Y%zE8Mvc$-`A!`%0YE2clxUDckt;mnHae#cr#iE{@E*xHN@<}^O!;Ym-h zU_MNakohr#H@0l0A=fy<8=8BcKE8f0Ilx`@^8Eq@>Bn{Vt9f3Xu$4G>S_O;gJ2pP; z-=5oD8oPMPr&S+c$j_9#Y~s51{QLH^jn6C13e;yxZoT%G$=zj25Km3Qyk-PnJ@@7BQEb@JS zLjPuSX$;f{JDx4o{%o^9OJ}##@sA%?i_E*Yr{rnb?zwe~zWz99sITe&-61}AX2;tf^MU#AEpQA_8fJaOq8hkdl>{;SBJ=^E2zH`S}Gu6p<1Pp@tM{YmcmXmV^0 zv)s9Dy@q+o|6e}exVN{q@9oR?@`svd757w1FaKDw&G_?=ZMi*vZORNM8$Q4BelJ^v zf0LT)g(V!bL>wn8WdyPKb}jG}G|{A^;8PR7<<;vM@16Z-c5Kggr3ZWGe7j$_|GU(K zyE(;v)+Un63-{iu=KYZO=E9O4x$Z84LYn*UrM9RKO3sCkZx>Frd!fnZ0VH|s_fU^Zg#boFyt I=akR{08~4JTL1t6 diff --git a/packages/mobile/ios/StandardNotes.xcodeproj/project.pbxproj b/packages/mobile/ios/StandardNotes.xcodeproj/project.pbxproj index 34ee133d3..f817399f3 100644 --- a/packages/mobile/ios/StandardNotes.xcodeproj/project.pbxproj +++ b/packages/mobile/ios/StandardNotes.xcodeproj/project.pbxproj @@ -10,21 +10,15 @@ 00E356F31AD99517003FC87E /* StandardNotesTests.m in Sources */ = {isa = PBXBuildFile; fileRef = 00E356F21AD99517003FC87E /* StandardNotesTests.m */; }; 13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; }; 13B07FC11A68108700A75B9A /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.m */; }; - 1C2EEB3B45F4EB07AC795C77 /* (null) in Frameworks */ = {isa = PBXBuildFile; }; + 1C2EEB3B45F4EB07AC795C77 /* BuildFile in Frameworks */ = {isa = PBXBuildFile; }; 33BB1B14071EBE5978EBF3A8 /* libPods-StandardNotes-StandardNotesTests.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 04FCB5A3A3387CA3CFC82AA3 /* libPods-StandardNotes-StandardNotesTests.a */; }; BC8DEA834BF198E8511F04FF /* libPods-StandardNotesDev.a in Frameworks */ = {isa = PBXBuildFile; fileRef = 51F2D747BE02C2A1BCFEEFD1 /* libPods-StandardNotesDev.a */; }; CD6592A9291EEFCC00C09DC6 /* StoreKit.framework in Frameworks */ = {isa = PBXBuildFile; fileRef = CD6592A8291EEFCC00C09DC6 /* StoreKit.framework */; }; CD7D5ECA27800609005FE1BF /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = CD7D5EC927800608005FE1BF /* LaunchScreen.storyboard */; }; CD7D5ED0278015D2005FE1BF /* main.m in Sources */ = {isa = PBXBuildFile; fileRef = 13B07FB71A68108700A75B9A /* main.m */; }; - CD7D5ED4278015D2005FE1BF /* Red.png in Resources */ = {isa = PBXBuildFile; fileRef = CD7D83FE277FF8CB00915D89 /* Red.png */; }; CD7D5ED5278015D2005FE1BF /* Images.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = 13B07FB51A68108700A75B9A /* Images.xcassets */; }; - CD7D5ED6278015D2005FE1BF /* Red@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = CD7D83FF277FF8CB00915D89 /* Red@2x.png */; }; CD7D5ED7278015D2005FE1BF /* LaunchScreen.storyboard in Resources */ = {isa = PBXBuildFile; fileRef = CD7D5EC927800608005FE1BF /* LaunchScreen.storyboard */; }; - CD7D5ED8278015D2005FE1BF /* Red@3x.png in Resources */ = {isa = PBXBuildFile; fileRef = CD7D83FD277FF8CB00915D89 /* Red@3x.png */; }; CD7D5EE3278016E3005FE1BF /* Dev.xcassets in Resources */ = {isa = PBXBuildFile; fileRef = CD7D5EE2278016E3005FE1BF /* Dev.xcassets */; }; - CD7D8400277FF8CB00915D89 /* Red@3x.png in Resources */ = {isa = PBXBuildFile; fileRef = CD7D83FD277FF8CB00915D89 /* Red@3x.png */; }; - CD7D8401277FF8CB00915D89 /* Red.png in Resources */ = {isa = PBXBuildFile; fileRef = CD7D83FE277FF8CB00915D89 /* Red.png */; }; - CD7D8402277FF8CB00915D89 /* Red@2x.png in Resources */ = {isa = PBXBuildFile; fileRef = CD7D83FF277FF8CB00915D89 /* Red@2x.png */; }; CDC75796292552080019F4AF /* AppDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDC75795292552080019F4AF /* AppDelegate.mm */; }; CDC75797292552080019F4AF /* AppDelegate.mm in Sources */ = {isa = PBXBuildFile; fileRef = CDC75795292552080019F4AF /* AppDelegate.mm */; }; D261494528699DCE00B17102 /* Web.bundle in Resources */ = {isa = PBXBuildFile; fileRef = D261494428699DCE00B17102 /* Web.bundle */; }; @@ -67,9 +61,6 @@ CD7D5EE2278016E3005FE1BF /* Dev.xcassets */ = {isa = PBXFileReference; lastKnownFileType = folder.assetcatalog; path = Dev.xcassets; sourceTree = ""; }; CD7D5EE427801EFD005FE1BF /* SNDev.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; path = SNDev.entitlements; sourceTree = ""; }; CD7D5EE527801F10005FE1BF /* StandardNotes.entitlements */ = {isa = PBXFileReference; lastKnownFileType = text.plist.entitlements; name = StandardNotes.entitlements; path = StandardNotes/StandardNotes.entitlements; sourceTree = ""; }; - CD7D83FD277FF8CB00915D89 /* Red@3x.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "Red@3x.png"; sourceTree = ""; }; - CD7D83FE277FF8CB00915D89 /* Red.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = Red.png; sourceTree = ""; }; - CD7D83FF277FF8CB00915D89 /* Red@2x.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "Red@2x.png"; sourceTree = ""; }; CDC75795292552080019F4AF /* AppDelegate.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; name = AppDelegate.mm; path = StandardNotes/AppDelegate.mm; sourceTree = ""; }; D261494428699DCE00B17102 /* Web.bundle */ = {isa = PBXFileReference; lastKnownFileType = "wrapper.plug-in"; name = Web.bundle; path = ../html/Web.bundle; sourceTree = ""; }; ED297162215061F000B7C4FE /* JavaScriptCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = JavaScriptCore.framework; path = System/Library/Frameworks/JavaScriptCore.framework; sourceTree = SDKROOT; }; @@ -89,7 +80,7 @@ buildActionMask = 2147483647; files = ( CD6592A9291EEFCC00C09DC6 /* StoreKit.framework in Frameworks */, - 1C2EEB3B45F4EB07AC795C77 /* (null) in Frameworks */, + 1C2EEB3B45F4EB07AC795C77 /* BuildFile in Frameworks */, DD3D1CE428EC1C8BA0C49211 /* libPods-StandardNotes.a in Frameworks */, ); runOnlyForDeploymentPostprocessing = 0; @@ -144,11 +135,8 @@ CD7D5EE527801F10005FE1BF /* StandardNotes.entitlements */, 13B07FB51A68108700A75B9A /* Images.xcassets */, 13B07FB71A68108700A75B9A /* main.m */, - CD7D83FE277FF8CB00915D89 /* Red.png */, CD7D5EC8278005B6005FE1BF /* Info.plist */, - CD7D83FF277FF8CB00915D89 /* Red@2x.png */, CD7D5EC927800608005FE1BF /* LaunchScreen.storyboard */, - CD7D83FD277FF8CB00915D89 /* Red@3x.png */, ); name = StandardNotes; sourceTree = ""; @@ -318,11 +306,8 @@ buildActionMask = 2147483647; files = ( D261494528699DCE00B17102 /* Web.bundle in Resources */, - CD7D8401277FF8CB00915D89 /* Red.png in Resources */, 13B07FBF1A68108700A75B9A /* Images.xcassets in Resources */, - CD7D8402277FF8CB00915D89 /* Red@2x.png in Resources */, CD7D5ECA27800609005FE1BF /* LaunchScreen.storyboard in Resources */, - CD7D8400277FF8CB00915D89 /* Red@3x.png in Resources */, ); runOnlyForDeploymentPostprocessing = 0; }; @@ -330,13 +315,10 @@ isa = PBXResourcesBuildPhase; buildActionMask = 2147483647; files = ( - CD7D5ED4278015D2005FE1BF /* Red.png in Resources */, D261494628699DCE00B17102 /* Web.bundle in Resources */, CD7D5EE3278016E3005FE1BF /* Dev.xcassets in Resources */, CD7D5ED5278015D2005FE1BF /* Images.xcassets in Resources */, - CD7D5ED6278015D2005FE1BF /* Red@2x.png in Resources */, CD7D5ED7278015D2005FE1BF /* LaunchScreen.storyboard in Resources */, - CD7D5ED8278015D2005FE1BF /* Red@3x.png in Resources */, ); runOnlyForDeploymentPostprocessing = 0; }; diff --git a/packages/mobile/ios/StandardNotes/Info.plist b/packages/mobile/ios/StandardNotes/Info.plist index e3d8d7255..ae73e210c 100644 --- a/packages/mobile/ios/StandardNotes/Info.plist +++ b/packages/mobile/ios/StandardNotes/Info.plist @@ -10,18 +10,6 @@ $(EXECUTABLE_NAME) CFBundleIcons - CFBundleAlternateIcons - - Red - - CFBundleIconFiles - - Red - - UIPrerenderedIcon - - - CFBundlePrimaryIcon CFBundleIconFiles @@ -34,18 +22,6 @@ CFBundleIcons~ipad - CFBundleAlternateIcons - - Red - - CFBundleIconFiles - - Red - - UIPrerenderedIcon - - - CFBundlePrimaryIcon CFBundleIconFiles diff --git a/packages/mobile/ios/StandardNotesDev-Info.plist b/packages/mobile/ios/StandardNotesDev-Info.plist index 98055f141..a3e6beece 100644 --- a/packages/mobile/ios/StandardNotesDev-Info.plist +++ b/packages/mobile/ios/StandardNotesDev-Info.plist @@ -10,18 +10,6 @@ $(EXECUTABLE_NAME) CFBundleIcons~ipad - CFBundleAlternateIcons - - Red - - CFBundleIconFiles - - Red - - UIPrerenderedIcon - - - CFBundlePrimaryIcon CFBundleIconFiles diff --git a/packages/web/package.json b/packages/web/package.json index 99cb59897..f5e304ad0 100644 --- a/packages/web/package.json +++ b/packages/web/package.json @@ -3,7 +3,7 @@ "version": "3.152.1", "license": "AGPL-3.0-or-later", "main": "dist/app.js", - "author": "Standard Notes", + "author": "Standard Notes.", "private": true, "files": [ "dist"