Merge remote-tracking branch 'upstream/develop' into account-menu-splitted

# Conflicts:
#	app/assets/javascripts/directives/views/accountMenu.ts

app/assets/javascripts/components/AutocompleteTagHint.tsx

@@ -19,6 +19,7 @@ export const AutocompleteTagHint = observer(
 
     const onTagHintClick = async () => {
       await appState.noteTags.createAndAddNewTag();
+      appState.noteTags.setAutocompleteInputFocused(true);
     };
 
     const onFocus = () => {

app/assets/javascripts/components/AutocompleteTagInput.tsx

@@ -5,6 +5,7 @@ import { AppState } from '@/ui_models/app_state';
 import { AutocompleteTagResult } from './AutocompleteTagResult';
 import { AutocompleteTagHint } from './AutocompleteTagHint';
 import { observer } from 'mobx-react-lite';
+import { SNTag } from '@standardnotes/snjs';
 
 type Props = {
   appState: AppState;
@@ -41,8 +42,13 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
 
   const onSearchQueryChange = (event: Event) => {
     const query = (event.target as HTMLInputElement).value;
-    appState.noteTags.setAutocompleteSearchQuery(query);
-    appState.noteTags.searchActiveNoteAutocompleteTags();
+
+    if (query === '') {
+      appState.noteTags.clearAutocompleteSearch();
+    } else {
+      appState.noteTags.setAutocompleteSearchQuery(query);
+      appState.noteTags.searchActiveNoteAutocompleteTags();
+    }
   };
 
   const onFormSubmit = async (event: Event) => {
@@ -83,10 +89,6 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
     appState.noteTags.setAutocompleteInputFocused(false);
   };
 
-  useEffect(() => {
-    appState.noteTags.searchActiveNoteAutocompleteTags();
-  }, [appState.noteTags]);
-
   useEffect(() => {
     if (autocompleteInputFocused) {
       inputRef.current.focus();
@@ -120,7 +122,7 @@ export const AutocompleteTagInput = observer(({ appState }: Props) => {
             onBlur={closeOnBlur}
           >
             <div className="overflow-y-auto">
-              {autocompleteTagResults.map((tagResult) => (
+              {autocompleteTagResults.map((tagResult: SNTag) => (
                 <AutocompleteTagResult
                   key={tagResult.uuid}
                   appState={appState}