rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: avoid event propagation when deleting a tag

Browse Source
This commit is contained in:
Antonella Sgarlatta
2021-06-03 17:45:19 -03:00
parent a67039a184
commit 3d0c8d5cce
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/assets/javascripts/components/NoteTag.tsx
View File

@@ -18,8 +18,14 @@ export const NoteTag = observer(({ appState, tag }: Props) => {
appState.noteTags.removeTagFromActiveNote(tag); appState.noteTags.removeTagFromActiveNote(tag);
}; };
const onTagClick = () => { const onDeleteTagClick = (event: MouseEvent) => {
if (tagClicked) { event.stopImmediatePropagation();
event.stopPropagation();
deleteTag();
};
const onTagClick = (event: MouseEvent) => {
if (tagClicked && event.target !== deleteTagRef.current) {
setTagClicked(false); setTagClicked(false);
appState.setSelectedTag(tag); appState.setSelectedTag(tag);
} else { } else {
@@ -78,7 +84,7 @@ export const NoteTag = observer(({ appState, tag }: Props) => {
className="ml-2 -mr-1 border-0 p-0 bg-transparent cursor-pointer flex" className="ml-2 -mr-1 border-0 p-0 bg-transparent cursor-pointer flex"
onFocus={onFocus} onFocus={onFocus}
onBlur={onBlur} onBlur={onBlur}
onClick={deleteTag} onClick={onDeleteTagClick}
> >
<Icon <Icon
type="close" type="close"