chore: memoize plain editor ref function

2024-01-11 19:39:07 +05:30
parent 7bafde5be7
commit 3d895ca499
1 changed files with 65 additions and 62 deletions
--- a/packages/web/src/javascripts/Components/NoteView/PlainEditor/PlainEditor.tsx
+++ b/packages/web/src/javascripts/Components/NoteView/PlainEditor/PlainEditor.tsx
@@ -205,7 +205,8 @@ export const PlainEditor = forwardRef<PlainEditorInterface, Props>(
      }
    }, [spellcheck, previousSpellcheck])

-    const onRef = (ref: HTMLTextAreaElement | null) => {
+    const onRef = useCallback(
+      (ref: HTMLTextAreaElement | null) => {
        if (tabObserverDisposer.current || !ref) {
          return
        }
@@ -269,7 +270,9 @@ export const PlainEditor = forwardRef<PlainEditorInterface, Props>(
        observer.observe(editor.parentElement as HTMLElement, { childList: true })

        mutationObserver.current = observer
-    }
+      },
+      [application.keyboardService, controller],
+    )

    if (textareaUnloading) {
      return null