diff --git a/.eslintrc.json b/.eslintrc.json deleted file mode 100644 index 71577cd76..000000000 --- a/.eslintrc.json +++ /dev/null @@ -1,7 +0,0 @@ -{ - "extends": ["./node_modules/@standardnotes/config/src/.eslintrc"], - "rules": { - "max-classes-per-file": ["error", 1] - }, - "ignorePatterns": [".eslintrc.js", "*.webpack.*.js", "webpack-defaults.js", "jest.config.js", "__mocks__", "**/**/coverage"] -} diff --git a/.yarn/cache/babel-eslint-npm-10.1.0-6a6d2b1533-bdc1f62b6b.zip b/.yarn/cache/babel-eslint-npm-10.1.0-6a6d2b1533-bdc1f62b6b.zip deleted file mode 100644 index b7799f843..000000000 Binary files a/.yarn/cache/babel-eslint-npm-10.1.0-6a6d2b1533-bdc1f62b6b.zip and /dev/null differ diff --git a/common.eslintrc.js b/common.eslintrc.js new file mode 100644 index 000000000..e4f588ebb --- /dev/null +++ b/common.eslintrc.js @@ -0,0 +1,60 @@ +module.exports = { + root: true, + parser: '@typescript-eslint/parser', + extends: ['eslint:recommended', 'plugin:@typescript-eslint/recommended', 'prettier'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + plugins: ['@typescript-eslint', 'prettier'], + ignorePatterns: ['**/*.spec.ts'], + rules: { + 'standard/no-callback-literal': 0, // Disable this as we have too many callbacks relying on literals + 'no-throw-literal': 0, + camelcase: 'off', + 'sort-imports': 'off', + 'eol-last': 'error', + 'no-multiple-empty-lines': ['error', { max: 1, maxEOF: 0 }], + 'no-trailing-spaces': 'error', + '@typescript-eslint/no-explicit-any': 'warn', + '@typescript-eslint/no-unused-vars': [ + 'error', + { + vars: 'all', + args: 'after-used', + ignoreRestSiblings: false, + argsIgnorePattern: '^_', + varsIgnorePattern: '^_', + }, + ], + '@typescript-eslint/no-floating-promises': ['error'], + 'block-scoped-var': 'error', + 'comma-dangle': ['error', 'always-multiline'], + curly: ['error', 'all'], + 'no-confusing-arrow': 'error', + 'no-inline-comments': 'warn', + 'no-invalid-this': 'error', + 'no-return-assign': 'warn', + 'no-constructor-return': 'error', + 'no-duplicate-imports': 'error', + 'no-self-compare': 'error', + 'no-console': ['error', { allow: ['warn', 'error'] }], + 'no-unmodified-loop-condition': 'error', + 'no-unused-private-class-members': 'error', + 'object-curly-spacing': ['error', 'always'], + quotes: ['error', 'single', { avoidEscape: true }], + semi: ['error', 'never'], + 'prettier/prettier': [ + 'error', + { + singleQuote: true, + trailingComma: 'all', + printWidth: 120, + semi: false, + }, + { + usePrettierrc: false, + }, + ], + }, +} diff --git a/linter.tsconfig.json b/linter.tsconfig.json deleted file mode 100644 index ab671ac7f..000000000 --- a/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "exclude": ["node_modules"], - "extends": "./node_modules/@standardnotes/config/src/linter.tsconfig.json" -} diff --git a/packages/api/.eslintignore b/packages/api/.eslintignore deleted file mode 100644 index 5a19e8ace..000000000 --- a/packages/api/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -coverage \ No newline at end of file diff --git a/packages/api/.eslintrc b/packages/api/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/api/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/api/.eslintrc.js b/packages/api/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/api/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/api/linter.tsconfig.json b/packages/api/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/api/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/api/package.json b/packages/api/package.json index 5c4545aa2..c49d54a00 100644 --- a/packages/api/package.json +++ b/packages/api/package.json @@ -21,8 +21,8 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", - "lint:fix": "eslint . --ext .ts --fix", + "lint": "eslint src --ext .ts", + "lint:fix": "eslint src --ext .ts --fix", "test": "jest spec --coverage" }, "devDependencies": { diff --git a/packages/desktop/.eslintignore b/packages/desktop/.eslintignore deleted file mode 100644 index 50a1ac7f7..000000000 --- a/packages/desktop/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -jsign \ No newline at end of file diff --git a/packages/desktop/.eslintrc b/packages/desktop/.eslintrc deleted file mode 100644 index 726947f29..000000000 --- a/packages/desktop/.eslintrc +++ /dev/null @@ -1,16 +0,0 @@ -{ - "env": { - "node": true, - "commonjs": true - }, - "extends": ["../../.eslintrc.json"], - "rules": { - "no-console": "off", - "@typescript-eslint/no-explicit-any": "warn", - "@typescript-eslint/no-var-requires": "off" - }, - "globals": { - "zip": true - }, - "ignorePatterns": ["scripts"] -} diff --git a/packages/desktop/.eslintrc.js b/packages/desktop/.eslintrc.js new file mode 100644 index 000000000..5f101800d --- /dev/null +++ b/packages/desktop/.eslintrc.js @@ -0,0 +1,16 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts', '@types', 'node_modules', 'dist'], + rules: { + 'no-console': ['warn', { allow: ['warn', 'error'] }], + '@typescript-eslint/no-var-requires': 'off', + }, + globals: { + zip: true, + }, +} diff --git a/packages/desktop/app/javascripts/Renderer/Renderer.ts b/packages/desktop/app/javascripts/Renderer/Renderer.ts index eb9840662..09d07c29b 100644 --- a/packages/desktop/app/javascripts/Renderer/Renderer.ts +++ b/packages/desktop/app/javascripts/Renderer/Renderer.ts @@ -41,7 +41,7 @@ const loadAndStartApplication = async () => { window.device = await createDesktopDevice(remoteBridge) - window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL) + return window.startApplication(DEFAULT_SYNC_SERVER, window.device, window.enableUnfinishedFeatures, WEBSOCKET_URL) } window.onload = () => { @@ -154,5 +154,5 @@ window.electronMainEvents.handleWindowFocused(() => { }) window.electronMainEvents.handleInstallComponentComplete((_: IpcRendererEvent, data: any) => { - window.webClient.onComponentInstallationComplete(data.component, undefined) + void window.webClient.onComponentInstallationComplete(data.component, undefined) }) diff --git a/packages/desktop/linter.tsconfig.json b/packages/desktop/linter.tsconfig.json deleted file mode 100644 index ab3d8c031..000000000 --- a/packages/desktop/linter.tsconfig.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json" -} diff --git a/packages/desktop/package.json b/packages/desktop/package.json index cbd63b9f9..9ada6a088 100644 --- a/packages/desktop/package.json +++ b/packages/desktop/package.json @@ -22,8 +22,8 @@ "dev": "NODE_ENV=development webpack --config desktop.webpack.dev.js --watch", "format": "prettier --write .", "lint:eslint": "eslint app/index.ts app/application.ts app/javascripts/**/*.ts", - "lint:formatting": "prettier --check .", - "lint": "yarn lint:formatting && yarn lint:eslint", + "lint:formatting": "prettier --check app", + "lint": "yarn lint:formatting && yarn lint:eslint app", "tsc": "tsc --noEmit", "release:mac": "node scripts/build.mjs mac", "start": "electron ./app --enable-logging --icon _icon/icon.png", @@ -58,7 +58,6 @@ "@types/proxyquire": "^1.3.28", "@types/yauzl": "^2.10.0", "ava": "^4.3.3", - "babel-eslint": "^10.1.0", "babel-loader": "^8.2.5", "copy-webpack-plugin": "^10.2.4", "electron-builder": "23.3.3", diff --git a/packages/encryption/.eslintignore b/packages/encryption/.eslintignore deleted file mode 100644 index f06235c46..000000000 --- a/packages/encryption/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -node_modules -dist diff --git a/packages/encryption/.eslintrc b/packages/encryption/.eslintrc deleted file mode 100644 index 86b280b2c..000000000 --- a/packages/encryption/.eslintrc +++ /dev/null @@ -1,10 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - }, - "rules": { - "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }], - "@typescript-eslint/no-non-null-assertion": "warn" - } -} diff --git a/packages/encryption/.eslintrc.js b/packages/encryption/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/encryption/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/encryption/linter.tsconfig.json b/packages/encryption/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/encryption/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/encryption/package.json b/packages/encryption/package.json index d4b148e56..f5045d409 100644 --- a/packages/encryption/package.json +++ b/packages/encryption/package.json @@ -18,7 +18,7 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "format": "prettier --write src", "test": "jest" }, diff --git a/packages/features/.eslintignore b/packages/features/.eslintignore deleted file mode 100644 index f06235c46..000000000 --- a/packages/features/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -node_modules -dist diff --git a/packages/features/.eslintrc b/packages/features/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/features/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/features/.eslintrc.js b/packages/features/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/features/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/features/linter.tsconfig.json b/packages/features/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/features/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/features/package.json b/packages/features/package.json index c2ce650aa..e0fc1a2d8 100644 --- a/packages/features/package.json +++ b/packages/features/package.json @@ -21,7 +21,7 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest" }, "dependencies": { @@ -32,7 +32,8 @@ }, "devDependencies": { "@types/jest": "^28.1.5", - "@typescript-eslint/eslint-plugin": "^5.30.0", + "@typescript-eslint/eslint-plugin": "*", + "eslint": "*", "eslint-plugin-prettier": "*", "jest": "^28.1.2", "ts-jest": "^28.0.5", diff --git a/packages/filepicker/.eslintignore b/packages/filepicker/.eslintignore deleted file mode 100644 index 5d9f984e2..000000000 --- a/packages/filepicker/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -example diff --git a/packages/filepicker/.eslintrc b/packages/filepicker/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/filepicker/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/filepicker/.eslintrc.js b/packages/filepicker/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/filepicker/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/filepicker/example/package.json b/packages/filepicker/example/package.json index cc10f752a..623e2abb3 100644 --- a/packages/filepicker/example/package.json +++ b/packages/filepicker/example/package.json @@ -24,7 +24,6 @@ "@babel/preset-typescript": "^7.15.0", "@standardnotes/config": "^2.2.0", "@types/wicg-native-file-system": "^2020.6.0", - "babel-eslint": "^10.1.0", "babel-loader": "^8.2.3", "html-webpack-plugin": "^5.5.0", "ts-loader": "^9.2.6", diff --git a/packages/filepicker/linter.tsconfig.json b/packages/filepicker/linter.tsconfig.json deleted file mode 100644 index d0fc8e96f..000000000 --- a/packages/filepicker/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist", "example"] -} diff --git a/packages/filepicker/package.json b/packages/filepicker/package.json index eef825d7b..5bcbf486a 100644 --- a/packages/filepicker/package.json +++ b/packages/filepicker/package.json @@ -19,12 +19,13 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest" }, "devDependencies": { "@types/jest": "^28.1.5", "@typescript-eslint/eslint-plugin": "^5.30.0", + "eslint": "*", "eslint-plugin-prettier": "*", "jest": "^28.1.2", "ts-jest": "^28.0.5", diff --git a/packages/files/.eslintignore b/packages/files/.eslintignore deleted file mode 100644 index f06235c46..000000000 --- a/packages/files/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -node_modules -dist diff --git a/packages/files/.eslintrc b/packages/files/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/files/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/files/.eslintrc.js b/packages/files/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/files/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/files/linter.tsconfig.json b/packages/files/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/files/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/files/package.json b/packages/files/package.json index 3025b76b8..eed7050c3 100644 --- a/packages/files/package.json +++ b/packages/files/package.json @@ -19,12 +19,13 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest" }, "devDependencies": { "@types/jest": "^28.1.5", "@typescript-eslint/eslint-plugin": "^5.30.0", + "eslint": "*", "eslint-plugin-prettier": "*", "jest": "^28.1.2", "ts-jest": "^28.0.5" diff --git a/packages/mobile/.eslintignore b/packages/mobile/.eslintignore deleted file mode 100644 index e46c0592a..000000000 --- a/packages/mobile/.eslintignore +++ /dev/null @@ -1,9 +0,0 @@ -metro.config.js -html/**/* -node_modules -ios -e2e -android -fastlane -WebFrame -__tests__ \ No newline at end of file diff --git a/packages/mobile/.eslintrc b/packages/mobile/.eslintrc deleted file mode 100644 index 9f40a1fe6..000000000 --- a/packages/mobile/.eslintrc +++ /dev/null @@ -1,14 +0,0 @@ -{ - "env": { - "node": true, - "commonjs": true - }, - "extends": ["@react-native-community", "plugin:react-hooks/recommended", "../../.eslintrc.json"], - "rules": { - "no-console": "warn", - "@typescript-eslint/no-explicit-any": "warn", - "@typescript-eslint/no-var-requires": "off", - "eqeqeq": ["off"], - "no-void": ["off"] - } -} diff --git a/packages/mobile/.eslintrc.js b/packages/mobile/.eslintrc.js new file mode 100644 index 000000000..c597161d4 --- /dev/null +++ b/packages/mobile/.eslintrc.js @@ -0,0 +1,13 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js', 'plugin:react-hooks/recommended'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts', '__mocks__'], + plugins: ['@typescript-eslint', 'react', 'react-hooks', 'prettier'], + rules: { + 'no-console': 'warn', + } +} diff --git a/packages/mobile/package.json b/packages/mobile/package.json index 92d029351..4c1570c82 100644 --- a/packages/mobile/package.json +++ b/packages/mobile/package.json @@ -17,7 +17,7 @@ "ios-dev": "react-native run-ios --scheme StandardNotesDev", "ios-prod": "react-native run-ios --scheme StandardNotes", "lint:fix": "yarn lint --fix", - "lint": "yarn tsc && yarn eslint . --ext .ts,.tsx", + "lint": "yarn eslint src --ext .ts,.tsx", "pods": "yarn install:pods", "start": "react-native start", "tsc": "tsc --noEmit", diff --git a/packages/mobile/tsconfig.json b/packages/mobile/tsconfig.json index 9f6511fa5..749b74eea 100644 --- a/packages/mobile/tsconfig.json +++ b/packages/mobile/tsconfig.json @@ -17,16 +17,5 @@ "target": "esnext", "typeRoots": ["node_modules/@types", "./src/Types/*"] }, - "exclude": [ - "node_modules", - "babel.config.js", - "metro.config.js", - "jest.config.js", - "e2e", - "html", - "android", - "WebFrame", - "ios", - "fastlane" - ] + "include": ["src"] } diff --git a/packages/models/.eslintignore b/packages/models/.eslintignore deleted file mode 100644 index f06235c46..000000000 --- a/packages/models/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -node_modules -dist diff --git a/packages/models/.eslintrc b/packages/models/.eslintrc deleted file mode 100644 index 86b280b2c..000000000 --- a/packages/models/.eslintrc +++ /dev/null @@ -1,10 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - }, - "rules": { - "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }], - "@typescript-eslint/no-non-null-assertion": "warn" - } -} diff --git a/packages/models/.eslintrc.js b/packages/models/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/models/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/models/linter.tsconfig.json b/packages/models/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/models/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/models/package.json b/packages/models/package.json index 2a407742a..30202c958 100644 --- a/packages/models/package.json +++ b/packages/models/package.json @@ -18,7 +18,7 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest" }, "devDependencies": { diff --git a/packages/models/tsconfig.json b/packages/models/tsconfig.json index f3dac14ef..c82bc5e86 100644 --- a/packages/models/tsconfig.json +++ b/packages/models/tsconfig.json @@ -9,5 +9,5 @@ "src/**/*" ], "references": [], - "exclude": ["**/*.spec.ts", "dist", "node_modules"] + "exclude": ["**/*.spec.ts"] } diff --git a/packages/responses/.eslintignore b/packages/responses/.eslintignore deleted file mode 100644 index 5a19e8ace..000000000 --- a/packages/responses/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -coverage \ No newline at end of file diff --git a/packages/responses/.eslintrc b/packages/responses/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/responses/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/responses/.eslintrc.js b/packages/responses/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/responses/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/responses/linter.tsconfig.json b/packages/responses/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/responses/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/responses/package.json b/packages/responses/package.json index 8a00edc1e..ef4042c8a 100644 --- a/packages/responses/package.json +++ b/packages/responses/package.json @@ -20,12 +20,13 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest spec --coverage --passWithNoTests" }, "devDependencies": { "@types/jest": "^28.1.5", "@typescript-eslint/eslint-plugin": "^5.30.0", + "eslint": "*", "eslint-plugin-prettier": "*", "jest": "^28.1.2", "ts-jest": "^28.0.5" diff --git a/packages/services/.eslintignore b/packages/services/.eslintignore deleted file mode 100644 index 5a19e8ace..000000000 --- a/packages/services/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -coverage \ No newline at end of file diff --git a/packages/services/.eslintrc b/packages/services/.eslintrc deleted file mode 100644 index 42e723b15..000000000 --- a/packages/services/.eslintrc +++ /dev/null @@ -1,9 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - }, - "rules": { - "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }] - } -} diff --git a/packages/services/.eslintrc.js b/packages/services/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/services/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/services/linter.tsconfig.json b/packages/services/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/services/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/services/package.json b/packages/services/package.json index ca149ad95..c4a37c212 100644 --- a/packages/services/package.json +++ b/packages/services/package.json @@ -19,8 +19,8 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", - "lint:fix": "eslint . --ext .ts --fix", + "lint": "eslint src --ext .ts", + "lint:fix": "eslint src --ext .ts --fix", "test": "jest spec --coverage" }, "dependencies": { diff --git a/packages/sncrypto-common/.eslintignore b/packages/sncrypto-common/.eslintignore deleted file mode 100644 index 1521c8b76..000000000 --- a/packages/sncrypto-common/.eslintignore +++ /dev/null @@ -1 +0,0 @@ -dist diff --git a/packages/sncrypto-common/.eslintrc b/packages/sncrypto-common/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/sncrypto-common/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/sncrypto-common/.eslintrc.js b/packages/sncrypto-common/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/sncrypto-common/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/sncrypto-common/linter.tsconfig.json b/packages/sncrypto-common/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/sncrypto-common/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/sncrypto-common/package.json b/packages/sncrypto-common/package.json index 09116d172..5271b7d3e 100644 --- a/packages/sncrypto-common/package.json +++ b/packages/sncrypto-common/package.json @@ -20,12 +20,13 @@ "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", "watch": "tsc -p tsconfig.json --watch", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "yarn lint" }, "devDependencies": { "@typescript-eslint/eslint-plugin": "^5.30.0", "@typescript-eslint/parser": "^5.12.1", + "eslint": "*", "eslint-plugin-prettier": "^4.2.1", "typescript": "*" }, diff --git a/packages/sncrypto-web/.eslintignore b/packages/sncrypto-web/.eslintignore deleted file mode 100644 index 5752c5132..000000000 --- a/packages/sncrypto-web/.eslintignore +++ /dev/null @@ -1,4 +0,0 @@ -dist -test -*.config.js -test-server.js diff --git a/packages/sncrypto-web/.eslintrc b/packages/sncrypto-web/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/sncrypto-web/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/sncrypto-web/.eslintrc.js b/packages/sncrypto-web/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/sncrypto-web/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/sncrypto-web/linter.tsconfig.json b/packages/sncrypto-web/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/sncrypto-web/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/sncrypto-web/package.json b/packages/sncrypto-web/package.json index 61343ef03..ed81e5e71 100644 --- a/packages/sncrypto-web/package.json +++ b/packages/sncrypto-web/package.json @@ -19,7 +19,7 @@ "prebuild": "yarn clean", "build": "webpack --mode production && tsc", "watch": "webpack --mode production --watch", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test:e2e": "node test-server.js" }, "dependencies": { diff --git a/packages/snjs/.eslintignore b/packages/snjs/.eslintignore deleted file mode 100644 index 1a615092b..000000000 --- a/packages/snjs/.eslintignore +++ /dev/null @@ -1,9 +0,0 @@ -node_modules -dist -test -*.config.js -mocha/**/* -coverage -e2e-server.js -jest-global.ts -webpack.*.js \ No newline at end of file diff --git a/packages/snjs/.eslintrc b/packages/snjs/.eslintrc deleted file mode 100644 index 6d65c2b28..000000000 --- a/packages/snjs/.eslintrc +++ /dev/null @@ -1,9 +0,0 @@ -{ - "extends": "../../.eslintrc.json", - "parserOptions": { - "project": "./linter.tsconfig.json" - }, - "rules": { - "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }] - } -} diff --git a/packages/snjs/.eslintrc.js b/packages/snjs/.eslintrc.js new file mode 100644 index 000000000..58a8ba4e4 --- /dev/null +++ b/packages/snjs/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './lib/tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/snjs/jsdoc.json b/packages/snjs/jsdoc.json deleted file mode 100644 index 368911169..000000000 --- a/packages/snjs/jsdoc.json +++ /dev/null @@ -1,22 +0,0 @@ -{ - "source": { - "includePattern": ".+\\.js(doc|x)?$", - "include": ["lib"], - "exclude": ["node_modules"] - }, - "recurseDepth": 10, - "opts": { - "destination": "./docs/", - "recurse": true, - "template": "node_modules/docdash" - }, - "tags": { - "allowUnknownTags": true, - "dictionaries": ["jsdoc", "closure"] - }, - "docdash": { - "meta": { - "title": "SNJS Documentation" - } - } -} diff --git a/packages/snjs/package.json b/packages/snjs/package.json index 5a9011506..fdf48f4b3 100644 --- a/packages/snjs/package.json +++ b/packages/snjs/package.json @@ -24,7 +24,7 @@ "build": "yarn tsc && webpack --config webpack.prod.js", "docs": "jsdoc -c jsdoc.json", "tsc": "tsc --project lib/tsconfig.json && tscpaths -p lib/tsconfig.json -s lib -o dist/@types", - "lint": "yarn lint:tsc && yarn lint:eslint", + "lint": "yarn lint:eslint lib", "lint:eslint": "eslint --ext .ts lib/", "lint:fix": "eslint --fix --ext .ts lib/", "lint:tsc": "tsc --noEmit --emitDeclarationOnly false --project lib/tsconfig.json", diff --git a/packages/styles/.eslintignore b/packages/styles/.eslintignore deleted file mode 100644 index 70b3dbbba..000000000 --- a/packages/styles/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -webpack.config.js \ No newline at end of file diff --git a/packages/styles/.eslintrc.js b/packages/styles/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/styles/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/styles/.eslintrc.json b/packages/styles/.eslintrc.json deleted file mode 100644 index 1df2a47c5..000000000 --- a/packages/styles/.eslintrc.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": ["../../node_modules/@standardnotes/config/src/.eslintrc"], - "ignorePatterns": [".eslintrc.js", "webpack.config.js"] -} diff --git a/packages/styles/linter.tsconfig.json b/packages/styles/linter.tsconfig.json deleted file mode 100644 index ab3d8c031..000000000 --- a/packages/styles/linter.tsconfig.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json" -} diff --git a/packages/toast/.eslintignore b/packages/toast/.eslintignore deleted file mode 100644 index f06235c46..000000000 --- a/packages/toast/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -node_modules -dist diff --git a/packages/toast/.eslintrc.js b/packages/toast/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/toast/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/toast/.eslintrc.json b/packages/toast/.eslintrc.json deleted file mode 100644 index af2e9d049..000000000 --- a/packages/toast/.eslintrc.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": ["../../node_modules/@standardnotes/config/src/.eslintrc"], - "ignorePatterns": [".eslintrc.js", "*.webpack.*.js", "webpack-defaults.js", "jest.config.js", "__mocks__"] -} diff --git a/packages/toast/linter.tsconfig.json b/packages/toast/linter.tsconfig.json deleted file mode 100644 index ab3d8c031..000000000 --- a/packages/toast/linter.tsconfig.json +++ /dev/null @@ -1,3 +0,0 @@ -{ - "extends": "../../node_modules/@standardnotes/config/src/linter.tsconfig.json" -} diff --git a/packages/ui-services/.eslintignore b/packages/ui-services/.eslintignore deleted file mode 100644 index 5a19e8ace..000000000 --- a/packages/ui-services/.eslintignore +++ /dev/null @@ -1,3 +0,0 @@ -node_modules -dist -coverage \ No newline at end of file diff --git a/packages/ui-services/.eslintrc b/packages/ui-services/.eslintrc deleted file mode 100644 index 42e723b15..000000000 --- a/packages/ui-services/.eslintrc +++ /dev/null @@ -1,9 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - }, - "rules": { - "@typescript-eslint/no-explicit-any": ["warn", { "ignoreRestArgs": true }] - } -} diff --git a/packages/ui-services/.eslintrc.js b/packages/ui-services/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/ui-services/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/ui-services/linter.tsconfig.json b/packages/ui-services/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/ui-services/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/ui-services/package.json b/packages/ui-services/package.json index 784ef4b14..4e2fd62fa 100644 --- a/packages/ui-services/package.json +++ b/packages/ui-services/package.json @@ -19,7 +19,7 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest spec" }, "dependencies": { @@ -35,6 +35,7 @@ "@types/jest": "^28.1.5", "@typescript-eslint/eslint-plugin": "^5.30.0", "@typescript-eslint/parser": "^5.12.1", + "eslint": "*", "eslint-plugin-prettier": "*", "jest": "^28.1.2", "ts-jest": "^28.0.5", diff --git a/packages/utils/.eslintignore b/packages/utils/.eslintignore deleted file mode 100644 index f06235c46..000000000 --- a/packages/utils/.eslintignore +++ /dev/null @@ -1,2 +0,0 @@ -node_modules -dist diff --git a/packages/utils/.eslintrc b/packages/utils/.eslintrc deleted file mode 100644 index cb7136174..000000000 --- a/packages/utils/.eslintrc +++ /dev/null @@ -1,6 +0,0 @@ -{ - "extends": "../../.eslintrc", - "parserOptions": { - "project": "./linter.tsconfig.json" - } -} diff --git a/packages/utils/.eslintrc.js b/packages/utils/.eslintrc.js new file mode 100644 index 000000000..03c2d1558 --- /dev/null +++ b/packages/utils/.eslintrc.js @@ -0,0 +1,9 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts'], +} diff --git a/packages/utils/linter.tsconfig.json b/packages/utils/linter.tsconfig.json deleted file mode 100644 index c1a7d22c5..000000000 --- a/packages/utils/linter.tsconfig.json +++ /dev/null @@ -1,4 +0,0 @@ -{ - "extends": "./tsconfig.json", - "exclude": ["dist"] -} diff --git a/packages/utils/package.json b/packages/utils/package.json index 3f433feea..2f920a666 100644 --- a/packages/utils/package.json +++ b/packages/utils/package.json @@ -21,7 +21,7 @@ "start": "tsc -p tsconfig.json --watch", "prebuild": "yarn clean", "build": "tsc -p tsconfig.json", - "lint": "eslint . --ext .ts", + "lint": "eslint src --ext .ts", "test": "jest spec" }, "dependencies": { @@ -37,6 +37,7 @@ "@types/lodash": "^4.14.179", "@types/node": "^18.0.0", "@typescript-eslint/eslint-plugin": "^5.30.0", + "eslint": "*", "eslint-plugin-prettier": "*", "jest": "^28.1.2", "jsdom": "^20.0.0", diff --git a/packages/web/.eslintignore b/packages/web/.eslintignore deleted file mode 100644 index 8dfeefd0d..000000000 --- a/packages/web/.eslintignore +++ /dev/null @@ -1,7 +0,0 @@ -dist -node_modules -web.webpack-defaults.js -coverage -src/components -src/favicon -src/vendor \ No newline at end of file diff --git a/packages/web/.eslintrc b/packages/web/.eslintrc deleted file mode 100644 index d533e8431..000000000 --- a/packages/web/.eslintrc +++ /dev/null @@ -1,47 +0,0 @@ -{ - "root": true, - "parser": "@typescript-eslint/parser", - "extends": [ - "eslint:recommended", - "plugin:@typescript-eslint/recommended", - "prettier", - "plugin:react-hooks/recommended", - "../../node_modules/@standardnotes/config/src/.eslintrc" - ], - "plugins": ["@typescript-eslint", "react", "react-hooks"], - "ignorePatterns": [ - "node_modules", - "dist", - ".eslintrc.js", - "*.webpack.*.js", - "webpack-defaults.js", - "jest.config.js", - "__mocks__", - "src/components", - "src/favicon", - "src/vendor", - "coverage", - "*.config.js" - ], - "rules": { - "standard/no-callback-literal": 0, // Disable this as we have too many callbacks relying on literals - "no-throw-literal": 0, - "no-console": ["warn", { "allow": ["warn", "error"] }], - "semi": 1, - "camelcase": "warn", - "sort-imports": "off", - "react-hooks/rules-of-hooks": "error", - "react-hooks/exhaustive-deps": "error", - "eol-last": "error", - "no-multiple-empty-lines": ["error", { "max": 1, "maxEOF": 0 }], - "no-trailing-spaces": "error", - "@typescript-eslint/no-explicit-any": "warn", - "no-invalid-this": "warn" - }, - "env": { - "browser": true - }, - "globals": { - "__WEB_VERSION__": true - } -} diff --git a/packages/web/.eslintrc.js b/packages/web/.eslintrc.js new file mode 100644 index 000000000..1b03d69aa --- /dev/null +++ b/packages/web/.eslintrc.js @@ -0,0 +1,16 @@ +module.exports = { + root: true, + extends: ['../../common.eslintrc.js', 'plugin:react-hooks/recommended'], + parserOptions: { + project: './tsconfig.json', + tsconfigRootDir: __dirname, + }, + ignorePatterns: ['**/*.spec.ts', "__mocks__"], + plugins: ['@typescript-eslint', 'react', 'react-hooks', 'prettier'], + env: { + browser: true, + }, + globals: { + __WEB_VERSION__: true, + }, +} diff --git a/packages/web/src/javascripts/Components/ComponentView/ComponentView.tsx b/packages/web/src/javascripts/Components/ComponentView/ComponentView.tsx index a9894fa7f..240f6ec72 100644 --- a/packages/web/src/javascripts/Components/ComponentView/ComponentView.tsx +++ b/packages/web/src/javascripts/Components/ComponentView/ComponentView.tsx @@ -48,7 +48,7 @@ const ComponentView: FunctionComponent = ({ application, onLoad, compone const component: SNComponent = componentViewer.component const manageSubscription = useCallback(() => { - openSubscriptionDashboard(application) + void openSubscriptionDashboard(application) }, [application]) const reloadValidityStatus = useCallback(() => { diff --git a/packages/web/src/javascripts/Components/ContentListView/ContentListView.tsx b/packages/web/src/javascripts/Components/ContentListView/ContentListView.tsx index 999cd1a00..91ac7c59d 100644 --- a/packages/web/src/javascripts/Components/ContentListView/ContentListView.tsx +++ b/packages/web/src/javascripts/Components/ContentListView/ContentListView.tsx @@ -214,9 +214,9 @@ const ContentListView: FunctionComponent = ({ const panelResizeFinishCallback: ResizeFinishCallback = useCallback( (width, _lastLeft, _isMaxWidth, isCollapsed) => { if (selectedAsTag) { - navigationController.setPanelWidthForTag(selectedAsTag, width) + void navigationController.setPanelWidthForTag(selectedAsTag, width) } else { - application.setPreference(PrefKey.NotesPanelWidth, width).catch(console.error) + void application.setPreference(PrefKey.NotesPanelWidth, width).catch(console.error) } application.publishPanelDidResizeEvent(PANEL_NAME_NOTES, isCollapsed) }, diff --git a/packages/web/src/javascripts/Components/ContentListView/Daily/DailyContentList.tsx b/packages/web/src/javascripts/Components/ContentListView/Daily/DailyContentList.tsx index f7de8665d..47ff2b8c3 100644 --- a/packages/web/src/javascripts/Components/ContentListView/Daily/DailyContentList.tsx +++ b/packages/web/src/javascripts/Components/ContentListView/Daily/DailyContentList.tsx @@ -113,7 +113,7 @@ const DailyContentList: FunctionComponent = ({ const onClickTemplate = useCallback( (date: Date) => { setSelectedDay(date) - itemListController.createNewNote(undefined, date, 'editor') + void itemListController.createNewNote(undefined, date, 'editor') toggleAppPane(AppPaneId.Editor) }, [setSelectedDay, itemListController, toggleAppPane], diff --git a/packages/web/src/javascripts/Components/ContentListView/Header/DisplayOptionsMenu.tsx b/packages/web/src/javascripts/Components/ContentListView/Header/DisplayOptionsMenu.tsx index 2528ff174..4986fae37 100644 --- a/packages/web/src/javascripts/Components/ContentListView/Header/DisplayOptionsMenu.tsx +++ b/packages/web/src/javascripts/Components/ContentListView/Header/DisplayOptionsMenu.tsx @@ -101,7 +101,7 @@ const DisplayOptionsMenu: FunctionComponent = ({ ) const resetTagPreferences = useCallback(() => { - application.mutator.changeAndSaveItem(selectedTag, (mutator) => { + void application.mutator.changeAndSaveItem(selectedTag, (mutator) => { mutator.preferences = undefined }) }, [application, selectedTag]) diff --git a/packages/web/src/javascripts/Components/ContentListView/Header/NewNotePreferences.tsx b/packages/web/src/javascripts/Components/ContentListView/Header/NewNotePreferences.tsx index deca42378..0b28c855c 100644 --- a/packages/web/src/javascripts/Components/ContentListView/Header/NewNotePreferences.tsx +++ b/packages/web/src/javascripts/Components/ContentListView/Header/NewNotePreferences.tsx @@ -101,7 +101,7 @@ const NewNotePreferences: FunctionComponent = ({ const setNewNoteTitleFormatChange = (value: string) => { setNewNoteTitleFormat(value as NewNoteTitleFormat) if (mode === 'global') { - application.setPreference(PrefKey.NewNoteTitleFormat, value as NewNoteTitleFormat) + void application.setPreference(PrefKey.NewNoteTitleFormat, value as NewNoteTitleFormat) } else { void changePreferencesCallback({ newNoteTitleFormat: value as NewNoteTitleFormat }) } @@ -168,7 +168,7 @@ const NewNotePreferences: FunctionComponent = ({ if (mode === 'tag') { void changePreferencesCallback({ customNoteTitleFormat: newFormat }) } else { - application.setPreference(PrefKey.CustomNoteTitleFormat, newFormat) + void application.setPreference(PrefKey.CustomNoteTitleFormat, newFormat) } }, PrefChangeDebounceTimeInMs) } diff --git a/packages/web/src/javascripts/Components/FilePreview/PreviewComponent.tsx b/packages/web/src/javascripts/Components/FilePreview/PreviewComponent.tsx index cb2dfb875..10c0116de 100644 --- a/packages/web/src/javascripts/Components/FilePreview/PreviewComponent.tsx +++ b/packages/web/src/javascripts/Components/FilePreview/PreviewComponent.tsx @@ -50,7 +50,7 @@ const PreviewComponent: FunctionComponent = ({ application, file, bytes } }), ) - application.mobileDevice().previewFile(fileBase64, file.name) + void application.mobileDevice().previewFile(fileBase64, file.name) }, [application, bytes, file.mimeType, file.name, isNativeMobileWeb]) useEffect(() => { diff --git a/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx b/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx index ebc4ef877..888da172d 100644 --- a/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx +++ b/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx @@ -61,14 +61,14 @@ const LinkedItemBubble = ({ const onUnlinkClick: MouseEventHandler = (event) => { event.stopPropagation() - unlinkItem(link) + void unlinkItem(link) } const onKeyDown: KeyboardEventHandler = (event) => { switch (event.key) { case KeyboardKey.Backspace: { focusPreviousItem() - unlinkItem(link) + void unlinkItem(link) break } case KeyboardKey.Left: diff --git a/packages/web/src/javascripts/Components/LinkedItems/LinkedItemSearchResults.tsx b/packages/web/src/javascripts/Components/LinkedItems/LinkedItemSearchResults.tsx index 2e2139528..76410c9b7 100644 --- a/packages/web/src/javascripts/Components/LinkedItems/LinkedItemSearchResults.tsx +++ b/packages/web/src/javascripts/Components/LinkedItems/LinkedItemSearchResults.tsx @@ -43,7 +43,7 @@ const LinkedItemSearchResults = ({ if (cannotLinkItem) { premiumModal.activate('Note linking') } else { - linkItemToSelectedItem(result) + void linkItemToSelectedItem(result) onClickCallback?.() } }} @@ -62,7 +62,7 @@ const LinkedItemSearchResults = ({