feat: Super notes can now be exported as PDF (#2776)

packages/web/src/javascripts/Components/NotesOptions/NotesOptions.tsx

@@ -142,6 +142,22 @@ const NotesOptions = ({ notes, closeMenu }: NotesOptionsProps) => {
     downloadSelectedItems().catch(console.error)
   }, [downloadSelectedItems, notes])
 
+  const shareSelectedItems = useCallback(() => {
+    createNoteExport(application, notes)
+      .then((result) => {
+        if (!result) {
+          return
+        }
+
+        const { blob, fileName } = result
+
+        shareBlobOnMobile(application.mobileDevice, application.isNativeMobileWeb(), blob, fileName).catch(
+          console.error,
+        )
+      })
+      .catch(console.error)
+  }, [application, notes])
+
   const closeMenuAndToggleNotesList = useCallback(() => {
     const isMobileScreen = matchMedia(MutuallyExclusiveMediaQueryBreakpoints.sm).matches
     if (isMobileScreen) {
@@ -347,34 +363,14 @@ const NotesOptions = ({ notes, closeMenu }: NotesOptionsProps) => {
             {pinShortcut && <KeyboardShortcutIndicator className="ml-auto" shortcut={pinShortcut} />}
           </MenuItem>
         )}
-        <MenuItem
-          onClick={() => {
-            if (application.isNativeMobileWeb()) {
-              createNoteExport(application, notes)
-                .then((result) => {
-                  if (!result) {
-                    return
-                  }
-
-                  const { blob, fileName } = result
-
-                  shareBlobOnMobile(application.mobileDevice, application.isNativeMobileWeb(), blob, fileName).catch(
-                    console.error,
-                  )
-                })
-                .catch(console.error)
-            } else {
-              exportSelectedItems()
-            }
-          }}
-        >
-          <Icon type={application.platform === Platform.Android ? 'share' : 'download'} className={iconClass} />
-          {application.platform === Platform.Android ? 'Share' : 'Export'}
+        <MenuItem onClick={exportSelectedItems}>
+          <Icon type="download" className={iconClass} />
+          Export
         </MenuItem>
         {application.platform === Platform.Android && (
-          <MenuItem onClick={exportSelectedItems}>
-            <Icon type="download" className={iconClass} />
-            Export
+          <MenuItem onClick={shareSelectedItems}>
+            <Icon type="share" className={iconClass} />
+            Share
           </MenuItem>
         )}
         <MenuItem onClick={duplicateSelectedItems} disabled={areSomeNotesInReadonlySharedVault}>

packages/web/src/javascripts/Components/NotesOptions/SuperExportModal.tsx

@@ -15,6 +15,7 @@ type Props = {
 
 const SuperExportModal = ({ notes, exportNotes, close }: Props) => {
   const application = useApplication()
+
   const superNoteExportFormat = usePreference(PrefKey.SuperNoteExportFormat)
   const superNoteExportEmbedBehavior = usePreference(PrefKey.SuperNoteExportEmbedBehavior)
   const superNoteExportUseMDFrontmatter = usePreference(PrefKey.SuperNoteExportUseMDFrontmatter)
@@ -26,10 +27,15 @@ const SuperExportModal = ({ notes, exportNotes, close }: Props) => {
     if (superNoteExportFormat === 'md' && superNoteExportEmbedBehavior === 'reference') {
       void application.setPreference(PrefKey.SuperNoteExportEmbedBehavior, 'separate')
     }
+    if (superNoteExportFormat === 'pdf' && superNoteExportEmbedBehavior !== 'inline') {
+      void application.setPreference(PrefKey.SuperNoteExportEmbedBehavior, 'inline')
+    }
   }, [application, superNoteExportEmbedBehavior, superNoteExportFormat])
 
   const someNotesHaveEmbeddedFiles = notes.some(noteHasEmbeddedFiles)
 
+  const canShowEmbeddedFileOptions = !['json', 'pdf'].includes(superNoteExportFormat)
+
   return (
     <Modal
       title="Export notes"
@@ -61,6 +67,7 @@ const SuperExportModal = ({ notes, exportNotes, close }: Props) => {
             { label: 'Super (.json)', value: 'json' },
             { label: 'Markdown (.md)', value: 'md' },
             { label: 'HTML', value: 'html' },
+            { label: 'PDF', value: 'pdf' },
           ]}
           value={superNoteExportFormat}
           onChange={(value) => {
@@ -93,7 +100,7 @@ const SuperExportModal = ({ notes, exportNotes, close }: Props) => {
           </Switch>
         </div>
       )}
-      {superNoteExportFormat !== 'json' && someNotesHaveEmbeddedFiles && (
+      {canShowEmbeddedFileOptions && someNotesHaveEmbeddedFiles && (
         <div className="mb-2 mt-4">
           <div className="mb-1">How do you want embedded files to be handled?</div>
           <RadioButtonGroup