chore: upgrade eslint and prettier (#2376)

* chore: upgrade eslint and prettier

* chore: add restrict-template-expressions

packages/models/src/Domain/Abstract/Content/ItemContent.ts

@@ -38,7 +38,7 @@ export function FillItemContent<C extends ItemContent = ItemContent>(content: Pa
   }
 
   if (!content.appData[DefaultAppDomain][AppDataField.UserModifiedDate]) {
-    content.appData[DefaultAppDomain][AppDataField.UserModifiedDate] = `${new Date()}`
+    content.appData[DefaultAppDomain][AppDataField.UserModifiedDate] = new Date().toString()
   }
 
   return content as C

packages/models/src/Domain/Abstract/Reference/Functions.ts

@@ -7,13 +7,14 @@ import { LegacyAnonymousReference } from './LegacyAnonymousReference'
 import { LegacyTagToNoteReference } from './LegacyTagToNoteReference'
 import { Reference } from './Reference'
 import { TagToParentTagReference } from './TagToParentTagReference'
+import { AnonymousReference } from './AnonymousReference'
 
 export const isLegacyAnonymousReference = (x: ContentReference): x is LegacyAnonymousReference => {
-  return (x as any).reference_type === undefined
+  return (x as AnonymousReference).reference_type === undefined
 }
 
 export const isReference = (x: ContentReference): x is Reference => {
-  return (x as any).reference_type !== undefined
+  return (x as AnonymousReference).reference_type !== undefined
 }
 
 export const isLegacyTagToNoteReference = (

packages/models/src/Domain/Runtime/Collection/Item/ItemCounter.ts

@@ -24,7 +24,10 @@ export class ItemCounter implements SNIndex {
   private displayOptions?: AnyDisplayOptions
   private vaultDisplayOptions?: VaultDisplayOptions
 
-  constructor(private collection: ItemCollection, public observers: TagItemCountChangeObserver[] = []) {}
+  constructor(
+    private collection: ItemCollection,
+    public observers: TagItemCountChangeObserver[] = [],
+  ) {}
 
   public addCountChangeObserver(observer: TagItemCountChangeObserver): () => void {
     this.observers.push(observer)

packages/models/src/Domain/Runtime/Display/Validator/CollectionCriteriaValidator.ts

@@ -3,7 +3,10 @@ import { ReadonlyItemCollection } from '../Types'
 import { CriteriaValidatorInterface } from './CriteriaValidatorInterface'
 
 export class CollectionCriteriaValidator implements CriteriaValidatorInterface {
-  constructor(private collection: ReadonlyItemCollection, private element: ItemInterface) {}
+  constructor(
+    private collection: ReadonlyItemCollection,
+    private element: ItemInterface,
+  ) {}
 
   public passes(): boolean {
     return this.collection.has(this.element.uuid)

packages/models/src/Domain/Runtime/Display/Validator/CustomFilterCriteriaValidator.ts

@@ -3,7 +3,10 @@ import { DisplayControllerCustomFilter } from '../Types'
 import { CriteriaValidatorInterface } from './CriteriaValidatorInterface'
 
 export class CustomFilterCriteriaValidator implements CriteriaValidatorInterface {
-  constructor(private customFilter: DisplayControllerCustomFilter, private element: DecryptedItemInterface) {}
+  constructor(
+    private customFilter: DisplayControllerCustomFilter,
+    private element: DecryptedItemInterface,
+  ) {}
 
   public passes(): boolean {
     return this.customFilter(this.element)

packages/models/src/Domain/Runtime/Display/Validator/ExcludeVaultsCriteriaValidator.ts

@@ -3,7 +3,10 @@ import { DecryptedItemInterface } from '../../../Abstract/Item'
 import { KeySystemIdentifier } from '../../../Syncable/KeySystemRootKey/KeySystemIdentifier'
 
 export class ExcludeVaultsCriteriaValidator implements CriteriaValidatorInterface {
-  constructor(private excludeVaults: KeySystemIdentifier[], private element: DecryptedItemInterface) {}
+  constructor(
+    private excludeVaults: KeySystemIdentifier[],
+    private element: DecryptedItemInterface,
+  ) {}
 
   public passes(): boolean {
     const doesElementBelongToExcludedVault = this.excludeVaults.some(

packages/models/src/Domain/Runtime/Display/Validator/ExclusiveVaultCriteriaValidator.ts

@@ -3,7 +3,10 @@ import { DecryptedItemInterface } from '../../../Abstract/Item'
 import { KeySystemIdentifier } from '../../../Syncable/KeySystemRootKey/KeySystemIdentifier'
 
 export class ExclusiveVaultCriteriaValidator implements CriteriaValidatorInterface {
-  constructor(private exclusiveVault: KeySystemIdentifier, private element: DecryptedItemInterface) {}
+  constructor(
+    private exclusiveVault: KeySystemIdentifier,
+    private element: DecryptedItemInterface,
+  ) {}
 
   public passes(): boolean {
     return this.element.key_system_identifier === this.exclusiveVault

packages/models/src/Domain/Runtime/Display/Validator/HiddenContentCriteriaValidator.ts

@@ -2,7 +2,10 @@ import { DecryptedItemInterface } from './../../../Abstract/Item/Interfaces/Decr
 import { CriteriaValidatorInterface } from './CriteriaValidatorInterface'
 
 export class HiddenContentCriteriaValidator implements CriteriaValidatorInterface {
-  constructor(private hiddenContentTypes: string[], private element: DecryptedItemInterface) {}
+  constructor(
+    private hiddenContentTypes: string[],
+    private element: DecryptedItemInterface,
+  ) {}
 
   public passes(): boolean {
     return !this.hiddenContentTypes.includes(this.element.content_type)

packages/models/src/Domain/Runtime/Predicate/Generators.ts

@@ -81,7 +81,7 @@ export function predicateFromDSLString<T extends PredicateTarget>(dsl: string):
     const predicateJson = predicateDSLArrayToJsonPredicate(components as RawPredicateInArrayForm)
     return predicateFromJson(predicateJson)
   } catch (e) {
-    throw Error(`Invalid smart view syntax ${e}`)
+    throw Error(`Invalid smart view syntax ${JSON.stringify(e)}`)
   }
 }
 

packages/models/src/Domain/Runtime/Predicate/IncludesPredicate.ts

@@ -1,7 +1,10 @@
 import { PredicateTarget, PredicateInterface, PredicateJsonForm, StringKey } from './Interface'
 
 export class IncludesPredicate<T extends PredicateTarget> implements PredicateInterface<T> {
-  constructor(private readonly keypath: StringKey<T>, public readonly predicate: PredicateInterface<T>) {}
+  constructor(
+    private readonly keypath: StringKey<T>,
+    public readonly predicate: PredicateInterface<T>,
+  ) {}
 
   matchesItem(item: T): boolean {
     const keyPathComponents = this.keypath.split('.') as StringKey<T>[]

packages/models/src/Domain/Runtime/Predicate/Interface.ts

@@ -13,7 +13,7 @@ export interface PredicateJsonForm {
 }
 
 export const AllPredicateCompoundOperators = ['and', 'or'] as const
-export type PredicateCompoundOperator = typeof AllPredicateCompoundOperators[number]
+export type PredicateCompoundOperator = (typeof AllPredicateCompoundOperators)[number]
 
 export const AllNonCompoundPredicateOperators = [
   '!=',
@@ -31,7 +31,7 @@ export const AllNonCompoundPredicateOperators = [
 
 export const AllPredicateOperators = [...AllPredicateCompoundOperators, ...AllNonCompoundPredicateOperators] as const
 
-export type PredicateOperator = typeof AllPredicateOperators[number]
+export type PredicateOperator = (typeof AllPredicateOperators)[number]
 
 export type SureValue = number | number[] | string[] | string | Date | boolean | false | ''