chore: upgrade eslint and prettier (#2376)

* chore: upgrade eslint and prettier

* chore: add restrict-template-expressions

packages/snjs/lib/Application/Event.ts

@@ -1,24 +1,23 @@
 import { ApplicationEvent, SyncEvent } from '@standardnotes/services'
-export { SyncEvent }
 
-export function applicationEventForSyncEvent(syncEvent: SyncEvent) {
-  return (
-    {
-      [SyncEvent.SyncCompletedWithAllItemsUploaded]: ApplicationEvent.CompletedFullSync,
-      [SyncEvent.PaginatedSyncRequestCompleted]: ApplicationEvent.CompletedIncrementalSync,
-      [SyncEvent.SyncError]: ApplicationEvent.FailedSync,
-      [SyncEvent.SyncTakingTooLong]: ApplicationEvent.HighLatencySync,
-      [SyncEvent.EnterOutOfSync]: ApplicationEvent.EnteredOutOfSync,
-      [SyncEvent.ExitOutOfSync]: ApplicationEvent.ExitedOutOfSync,
-      [SyncEvent.LocalDataLoaded]: ApplicationEvent.LocalDataLoaded,
-      [SyncEvent.MajorDataChange]: ApplicationEvent.MajorDataChange,
-      [SyncEvent.LocalDataIncrementalLoad]: ApplicationEvent.LocalDataIncrementalLoad,
-      [SyncEvent.StatusChanged]: ApplicationEvent.SyncStatusChanged,
-      [SyncEvent.SyncDidBeginProcessing]: ApplicationEvent.WillSync,
-      [SyncEvent.InvalidSession]: ApplicationEvent.InvalidSyncSession,
-      [SyncEvent.DatabaseReadError]: ApplicationEvent.LocalDatabaseReadError,
-      [SyncEvent.DatabaseWriteError]: ApplicationEvent.LocalDatabaseWriteError,
-      [SyncEvent.DownloadFirstSyncCompleted]: ApplicationEvent.CompletedInitialSync,
-    } as any
-  )[syncEvent]
+const map: Record<string, ApplicationEvent> = {
+  [SyncEvent.SyncCompletedWithAllItemsUploaded]: ApplicationEvent.CompletedFullSync,
+  [SyncEvent.PaginatedSyncRequestCompleted]: ApplicationEvent.CompletedIncrementalSync,
+  [SyncEvent.SyncError]: ApplicationEvent.FailedSync,
+  [SyncEvent.SyncTakingTooLong]: ApplicationEvent.HighLatencySync,
+  [SyncEvent.EnterOutOfSync]: ApplicationEvent.EnteredOutOfSync,
+  [SyncEvent.ExitOutOfSync]: ApplicationEvent.ExitedOutOfSync,
+  [SyncEvent.LocalDataLoaded]: ApplicationEvent.LocalDataLoaded,
+  [SyncEvent.MajorDataChange]: ApplicationEvent.MajorDataChange,
+  [SyncEvent.LocalDataIncrementalLoad]: ApplicationEvent.LocalDataIncrementalLoad,
+  [SyncEvent.StatusChanged]: ApplicationEvent.SyncStatusChanged,
+  [SyncEvent.SyncDidBeginProcessing]: ApplicationEvent.WillSync,
+  [SyncEvent.InvalidSession]: ApplicationEvent.InvalidSyncSession,
+  [SyncEvent.DatabaseReadError]: ApplicationEvent.LocalDatabaseReadError,
+  [SyncEvent.DatabaseWriteError]: ApplicationEvent.LocalDatabaseWriteError,
+  [SyncEvent.DownloadFirstSyncCompleted]: ApplicationEvent.CompletedInitialSync,
+}
+
+export function applicationEventForSyncEvent(syncEvent: SyncEvent): ApplicationEvent | undefined {
+  return map[syncEvent]
 }

packages/snjs/lib/ApplicationGroup/ApplicationGroup.ts

@@ -26,7 +26,10 @@ export class SNApplicationGroup<D extends DeviceInterface = DeviceInterface> ext
   private descriptorRecord!: DescriptorRecord
   callback!: AppGroupCallback<D>
 
-  constructor(public device: D, internalEventBus?: InternalEventBusInterface) {
+  constructor(
+    public device: D,
+    internalEventBus?: InternalEventBusInterface,
+  ) {
     if (internalEventBus === undefined) {
       internalEventBus = new InternalEventBus()
     }

packages/snjs/lib/Domain/UseCase/GetRecoveryCodes/GetRecoveryCodes.ts

@@ -5,7 +5,10 @@ import { SettingName } from '@standardnotes/settings'
 import { SettingsClientInterface } from '@Lib/Services/Settings/SettingsClientInterface'
 
 export class GetRecoveryCodes implements UseCaseInterface<string> {
-  constructor(private authClient: AuthClientInterface, private settingsClient: SettingsClientInterface) {}
+  constructor(
+    private authClient: AuthClientInterface,
+    private settingsClient: SettingsClientInterface,
+  ) {}
 
   async execute(): Promise<Result<string>> {
     const existingRecoveryCodes = await this.settingsClient.getSetting(

packages/snjs/lib/Services/ComponentManager/UseCase/GetDefaultEditorIdentifier.ts

@@ -4,7 +4,10 @@ import { ComponentInterface, PrefKey, SNTag } from '@standardnotes/models'
 import { ItemManagerInterface, PreferenceServiceInterface } from '@standardnotes/services'
 
 export class GetDefaultEditorIdentifier implements SyncUseCaseInterface<string> {
-  constructor(private preferences: PreferenceServiceInterface, private items: ItemManagerInterface) {}
+  constructor(
+    private preferences: PreferenceServiceInterface,
+    private items: ItemManagerInterface,
+  ) {}
 
   execute(currentTag?: SNTag): Result<string> {
     if (currentTag) {

packages/snjs/lib/Services/Features/FeaturesService.ts

@@ -250,7 +250,7 @@ export class FeaturesService
 
       return this.downloadOfflineRoles(offlineRepo)
     } catch (err) {
-      return new ClientDisplayableError(`${API_MESSAGE_FAILED_OFFLINE_ACTIVATION}, ${err}`)
+      return new ClientDisplayableError(`${API_MESSAGE_FAILED_OFFLINE_ACTIVATION}, ${JSON.stringify(err)}`)
     }
   }
 

packages/snjs/lib/Services/Features/UseCase/MigrateFeatureRepoToUserSetting.ts

@@ -4,7 +4,10 @@ import { MutatorClientInterface } from '@standardnotes/services'
 import { SettingName } from '@standardnotes/settings'
 
 export class MigrateFeatureRepoToUserSettingUseCase {
-  constructor(private mutator: MutatorClientInterface, private settings: SettingsClientInterface) {}
+  constructor(
+    private mutator: MutatorClientInterface,
+    private settings: SettingsClientInterface,
+  ) {}
 
   async execute(featureRepos: SNFeatureRepo[] = []): Promise<void> {
     for (const item of featureRepos) {

packages/snjs/lib/Services/Sync/SyncService.ts

@@ -641,7 +641,7 @@ export class SyncService
     } else if (useStrategy === SyncQueueStrategy.ForceSpawnNew) {
       return this.queueStrategyForceSpawnNew(options)
     } else {
-      throw Error(`Unhandled timing strategy ${useStrategy}`)
+      throw Error('Unhandled timing strategy')
     }
   }