From 4b173bdf643014a7136a8b21daa45743c45fe598 Mon Sep 17 00:00:00 2001 From: Johnny A <5891646+johnny243@users.noreply.github.com> Date: Wed, 19 Aug 2020 13:53:57 -0400 Subject: [PATCH] fix: actions not loading (#448) Co-authored-by: Johnny Almonte --- app/assets/javascripts/directives/views/actionsMenu.ts | 4 +--- app/assets/templates/directives/actions-menu.pug | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/app/assets/javascripts/directives/views/actionsMenu.ts b/app/assets/javascripts/directives/views/actionsMenu.ts index a85f2b7ba..04e465387 100644 --- a/app/assets/javascripts/directives/views/actionsMenu.ts +++ b/app/assets/javascripts/directives/views/actionsMenu.ts @@ -62,9 +62,7 @@ class ActionsMenuCtrl extends PureViewCtrl implements ActionsMenuScope { this.props.item ); })); - if (extensionsForItem.length == 0) { - this.loadingExtensions = false; - } + this.loadingExtensions = false; await this.setState({ extensions: extensionsForItem }); diff --git a/app/assets/templates/directives/actions-menu.pug b/app/assets/templates/directives/actions-menu.pug index 21ed0b287..79637acc9 100644 --- a/app/assets/templates/directives/actions-menu.pug +++ b/app/assets/templates/directives/actions-menu.pug @@ -12,7 +12,7 @@ .sk-menu-panel-column .sk-menu-panel-header-title Loading... .sk-spinner.small.loading - div(ng-repeat='extension in self.state.extensions track by extension.uuid; self.loadingExtensions = false') + div(ng-repeat='extension in self.state.extensions track by extension.uuid') .sk-menu-panel-header( ng-click='self.updateExtension(extension, { hidden: !extension.hidden }); $event.stopPropagation();' )