refactor: offline roles (#2169)

packages/web/src/javascripts/Components/Preferences/Panes/Account/Email.tsx

@@ -99,7 +99,7 @@ const Email: FunctionComponent<Props> = ({ application }: Props) => {
               <Subtitle>Disable sign-in notification emails</Subtitle>
               <Text>
                 Disables email notifications when a new sign-in occurs on your account. (Email notifications are
-                available to paid subscribers).
+                available only to paid subscribers).
               </Text>
             </div>
             {isLoading ? (

packages/web/src/javascripts/Components/Preferences/Panes/Account/Subscription/Subscription.tsx

@@ -15,7 +15,7 @@ type Props = {
 
 const Subscription: FunctionComponent<Props> = ({ application, viewControllerManager }: Props) => {
   const subscriptionState = viewControllerManager.subscriptionController
-  const { userSubscription } = subscriptionState
+  const { onlineSubscription } = subscriptionState
 
   const now = new Date().getTime()
 
@@ -25,7 +25,7 @@ const Subscription: FunctionComponent<Props> = ({ application, viewControllerMan
         <div className="flex flex-row items-center">
           <div className="flex flex-grow flex-col">
             <Title>Subscription</Title>
-            {userSubscription && userSubscription.endsAt > now ? (
+            {onlineSubscription && onlineSubscription.endsAt > now ? (
               <SubscriptionInformation subscriptionState={subscriptionState} application={application} />
             ) : (
               <NoSubscription application={application} />

packages/web/src/javascripts/Components/Preferences/Panes/Backups/CloudBackups/CloudBackupProvider.tsx

@@ -17,7 +17,7 @@ import {
 } from '@standardnotes/snjs'
 import { WebApplication } from '@/Application/Application'
 import Button from '@/Components/Button/Button'
-import { isDev, openInNewTab } from '@/Utils'
+import { openInNewTab } from '@/Utils'
 import { Subtitle } from '@/Components/Preferences/PreferencesComponents/Content'
 import { KeyboardKey } from '@standardnotes/ui-services'
 
@@ -61,7 +61,7 @@ const CloudBackupProvider: FunctionComponent<Props> = ({ application, providerNa
     }
     event.stopPropagation()
 
-    const authUrl = application.getCloudProviderIntegrationUrl(providerName, isDev)
+    const authUrl = application.getCloudProviderIntegrationUrl(providerName)
     openInNewTab(authUrl)
     setAuthBegan(true)
   }

packages/web/src/javascripts/Components/Preferences/Panes/General/Advanced/Packages/Provider/PackageProvider.ts

@@ -7,7 +7,7 @@ export class PackageProvider {
   static async load(application: WebApplication): Promise<PackageProvider | undefined> {
     const response = await application.getAvailableSubscriptions()
 
-    if (response instanceof ClientDisplayableError) {
+    if (!response || response instanceof ClientDisplayableError) {
       return undefined
     }