From 581a08cd09e02354676d9c14058475e71be05175 Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Wed, 21 Sep 2022 20:39:29 +0530
Subject: [PATCH] fix: tag input auto-submitting when pressing space (#1608)

---
 .../src/javascripts/Components/Tags/SmartViewsListItem.tsx  | 2 ++
 .../web/src/javascripts/Components/Tags/TagsListItem.tsx    | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx b/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
index 6679d4fd2..44d759ed0 100644
--- a/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
+++ b/packages/web/src/javascripts/Components/Tags/SmartViewsListItem.tsx
@@ -112,6 +112,8 @@ const SmartViewsListItem: FunctionComponent<Props> = ({ view, tagsState }) => {
   return (
     <>
       <div
+        role="button"
+        tabIndex={0}
         className={classNames('tag py-2 px-3.5 md:py-1', isSelected && 'selected', isFaded && 'opacity-50')}
         onClick={selectCurrentTag}
         style={{
diff --git a/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx b/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
index 0e9151e60..1673a9f60 100644
--- a/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
+++ b/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
@@ -202,7 +202,9 @@ export const TagsListItem: FunctionComponent<Props> = observer(({ tag, features,
 
   return (
     <>
-      <button
+      <div
+        role="button"
+        tabIndex={0}
         className={classNames(
           'tag py-2 px-3.5 focus:shadow-inner md:py-1',
           isSelected && 'selected',
@@ -272,7 +274,7 @@ export const TagsListItem: FunctionComponent<Props> = observer(({ tag, features,
         <div className={`meta ${hasAtLeastOneFolder ? 'with-folders' : ''}`}>
           {tag.conflictOf && <div className="danger text-[0.625rem] font-bold">Conflicted Copy {tag.conflictOf}</div>}
         </div>
-      </button>
+      </div>
       {isAddingSubtag && (
         <div
           className="tag overflow-hidden"