rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore: put vaults labs feature behind feature trunk

Browse Source
This commit is contained in:
Aman Harwara
2023-10-09 19:02:12 +05:30
parent 59f11e5b0e
commit 59532d8850
2 changed files with 23 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
packages/web/src/javascripts/Components/Preferences/Panes/General/Labs/Labs.tsx
View File

@@ -15,6 +15,7 @@ import PreferencesSegment from '../../../PreferencesComponents/PreferencesSegmen
import LabsFeature from './LabsFeature' import LabsFeature from './LabsFeature'
import HorizontalSeparator from '@/Components/Shared/HorizontalSeparator' import HorizontalSeparator from '@/Components/Shared/HorizontalSeparator'
import { MutuallyExclusiveMediaQueryBreakpoints, useMediaQuery } from '@/Hooks/useMediaQuery' import { MutuallyExclusiveMediaQueryBreakpoints, useMediaQuery } from '@/Hooks/useMediaQuery'
import { featureTrunkVaultsEnabled } from '@/FeatureTrunk'
type ExperimentalFeatureItem = { type ExperimentalFeatureItem = {
identifier: string identifier: string
@@ -48,18 +49,27 @@ const LabsPane: FunctionComponent<Props> = ({ application }) => {
}, [application]) }, [application])
const reloadExperimentalFeatures = useCallback(() => { const reloadExperimentalFeatures = useCallback(() => {
const experimentalFeatures = application.features.getExperimentalFeatures().map((featureIdentifier) => { const experimentalFeatures = application.features
const feature = FindNativeFeature(featureIdentifier) .getExperimentalFeatures()
return { .map((featureIdentifier) => {
identifier: featureIdentifier, const feature = FindNativeFeature(featureIdentifier)
name: feature?.name ?? featureIdentifier, return {
description: feature?.description ?? '', identifier: featureIdentifier,
isEnabled: application.features.isExperimentalFeatureEnabled(featureIdentifier), name: feature?.name ?? featureIdentifier,
isEntitled: description: feature?.description ?? '',
application.features.getFeatureStatus(NativeFeatureIdentifier.create(featureIdentifier).getValue()) === isEnabled: application.features.isExperimentalFeatureEnabled(featureIdentifier),
FeatureStatus.Entitled, isEntitled:
} application.features.getFeatureStatus(NativeFeatureIdentifier.create(featureIdentifier).getValue()) ===
}) FeatureStatus.Entitled,
}
})
.filter((feature) => {
if (feature.identifier !== NativeFeatureIdentifier.TYPES.Vaults) {
return true
}
return featureTrunkVaultsEnabled()
})
setExperimentalFeatures(experimentalFeatures) setExperimentalFeatures(experimentalFeatures)
}, [application]) }, [application])

3
packages/web/src/javascripts/FeatureTrunk.ts
View File

@@ -9,8 +9,7 @@ export function featureTrunkEnabled(trunk: FeatureTrunkName): boolean {
} }
export function featureTrunkVaultsEnabled(): boolean { export function featureTrunkVaultsEnabled(): boolean {
// return InternalFeatureService.get().isFeatureEnabled(InternalFeature.Vaults) return InternalFeatureService.get().isFeatureEnabled(InternalFeature.Vaults)
return false
} }
export function featureTrunkHomeServerEnabled(): boolean { export function featureTrunkHomeServerEnabled(): boolean {