From 5b99e5f90db68ce1939194083c63a7e63bcfcc5c Mon Sep 17 00:00:00 2001
From: Mo <mo@standardnotes.com>
Date: Sat, 15 Jan 2022 12:07:59 -0600
Subject: [PATCH] fix: move dev account in useEffect

---
 .../components/AccountMenu/AdvancedOptions.tsx   | 16 ++++++++++------
 .../components/AccountMenu/SignIn.tsx            |  9 ++++-----
 2 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/app/assets/javascripts/components/AccountMenu/AdvancedOptions.tsx b/app/assets/javascripts/components/AccountMenu/AdvancedOptions.tsx
index cdae6ca3c..93638dc38 100644
--- a/app/assets/javascripts/components/AccountMenu/AdvancedOptions.tsx
+++ b/app/assets/javascripts/components/AccountMenu/AdvancedOptions.tsx
@@ -3,7 +3,7 @@ import { AppState } from '@/ui_models/app_state';
 import { isDev } from '@/utils';
 import { observer } from 'mobx-react-lite';
 import { FunctionComponent } from 'preact';
-import { useState } from 'preact/hooks';
+import { useEffect, useState } from 'preact/hooks';
 import { Checkbox } from '../Checkbox';
 import { Icon } from '../Icon';
 import { InputWithIcon } from '../InputWithIcon';
@@ -20,11 +20,15 @@ export const AdvancedOptions: FunctionComponent<Props> = observer(
       appState.accountMenu;
     const [showAdvanced, setShowAdvanced] = useState(false);
 
-    if (isDev && window._devAccountServer) {
-      setEnableServerOption(true);
-      setServer(window._devAccountServer);
-      application.setCustomHost(window._devAccountServer);
-    }
+    useEffect(() => {
+      if (isDev && window._devAccountServer) {
+        setEnableServerOption(true);
+        setServer(window._devAccountServer);
+        application.setCustomHost(window._devAccountServer);
+      }
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+    }, []);
+
 
     const handleServerOptionChange = (e: Event) => {
       if (e.target instanceof HTMLInputElement) {
diff --git a/app/assets/javascripts/components/AccountMenu/SignIn.tsx b/app/assets/javascripts/components/AccountMenu/SignIn.tsx
index 82da576f3..6c0469840 100644
--- a/app/assets/javascripts/components/AccountMenu/SignIn.tsx
+++ b/app/assets/javascripts/components/AccountMenu/SignIn.tsx
@@ -33,15 +33,14 @@ export const SignInPane: FunctionComponent<Props> = observer(
     const emailInputRef = useRef<HTMLInputElement>(null);
     const passwordInputRef = useRef<HTMLInputElement>(null);
 
-    if (isDev && window._devAccountEmail) {
-      setEmail(window._devAccountEmail);
-      setPassword(window._devAccountPassword as string);
-    }
-
     useEffect(() => {
       if (emailInputRef?.current) {
         emailInputRef.current?.focus();
       }
+      if (isDev && window._devAccountEmail) {
+        setEmail(window._devAccountEmail);
+        setPassword(window._devAccountPassword as string);
+      }
     }, []);
 
     const resetInvalid = () => {