Fix modelManager sync observer now being syncronous

app/assets/javascripts/app/controllers/tags.js

@@ -30,28 +30,30 @@ angular.module('app')
         || syncEvent == "local-data-incremental-load") {
         this.tags = modelManager.tags;
         this.smartTags = modelManager.getSmartTags();
+        if(this.noteCountsNeedReload) {
+          this.noteCountsNeedReload = false;
+          this.reloadNoteCounts();
+        }
       }
     });
 
-    modelManager.addItemSyncObserver("note-list", "*", (allItems, validItems, deletedItems, source, sourceKey) => {
-      // recompute note counts
-      let tags = [];
-      if(this.tags) {
-        tags = tags.concat(this.tags);
-      }
-      if(this.smartTags) {
-        tags = tags.concat(this.smartTags);
-      }
+    modelManager.addItemSyncObserver("tags-list", "*", (allItems, validItems, deletedItems, source, sourceKey) => {
+      this.noteCountsNeedReload = true;
+    });
 
-      for(let tag of tags) {
-        var validNotes = SNNote.filterDummyNotes(tag.notes).filter(function(note){
+    this.reloadNoteCounts = function() {
+      let allTags = [];
+      if(this.tags) { allTags = allTags.concat(this.tags);}
+      if(this.smartTags) { allTags = allTags.concat(this.smartTags);}
+
+      for(let tag of allTags) {
+        var validNotes = SNNote.filterDummyNotes(tag.notes).filter((note) => {
           return !note.archived && !note.content.trashed;
         });
 
         tag.cachedNoteCount = validNotes.length;
       }
-    });
-
+    }
 
     this.panelController = {};
 

app/assets/templates/home.html.haml

@@ -3,8 +3,7 @@
   %lock-screen{"ng-if" => "needsUnlock", "on-success" => "onSuccessfulUnlock"}
 
   .app#app{"ng-if" => "!needsUnlock", "ng-class" => "appClass"}
-    %tags-section{"save" => "tagsSave", "add-new" => "tagsAddNew", "selection-made" => "tagsSelectionMade",
-     "tags" => "tags", "remove-tag" => "removeTag"}
+    %tags-section{"save" => "tagsSave", "add-new" => "tagsAddNew", "selection-made" => "tagsSelectionMade", "remove-tag" => "removeTag"}
     %notes-section{"add-new" => "notesAddNew", "selection-made" => "notesSelectionMade", "tag" => "selectedTag"}
     %editor-section{"note" => "selectedNote", "remove" => "deleteNote", "update-tags" => "updateTagsForNote"}