chore: app group optimizations (#1027)

2022-05-16 21:14:18 -05:00
parent 754a189532
commit 62cf34e894
108 changed files with 1796 additions and 1187 deletions
--- a/app/assets/javascripts/Components/AttachedFilesPopover/PopoverFileSubmenu.tsx
+++ b/app/assets/javascripts/Components/AttachedFilesPopover/PopoverFileSubmenu.tsx
@@ -34,11 +34,11 @@ export const PopoverFileSubmenu: FunctionComponent<Props> = ({
  })
  const [closeOnBlur] = useCloseOnBlur(menuContainerRef, setIsMenuOpen)

-  const closeMenu = () => {
+  const closeMenu = useCallback(() => {
    setIsMenuOpen(false)
-  }
+  }, [])

-  const toggleMenu = () => {
+  const toggleMenu = useCallback(() => {
    if (!isMenuOpen) {
      const menuPosition = calculateSubmenuStyle(menuButtonRef.current)
      if (menuPosition) {
@@ -47,7 +47,7 @@ export const PopoverFileSubmenu: FunctionComponent<Props> = ({
    }

    setIsMenuOpen(!isMenuOpen)
-  }
+  }, [isMenuOpen])

  const recalculateMenuStyle = useCallback(() => {
    const newMenuPosition = calculateSubmenuStyle(menuButtonRef.current, menuRef.current)