From 64d3b01b6b2a132803fc181f9aa6e8b7de9a16ed Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Fri, 27 Oct 2023 20:03:43 +0530 Subject: [PATCH] chore: dont add toolbar position update listeners on mobile as its unnecessary [skip e2e] --- .../SuperEditor/Plugins/ToolbarPlugin/ToolbarPlugin.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/web/src/javascripts/Components/SuperEditor/Plugins/ToolbarPlugin/ToolbarPlugin.tsx b/packages/web/src/javascripts/Components/SuperEditor/Plugins/ToolbarPlugin/ToolbarPlugin.tsx index 5f5068656..0012bcbd5 100644 --- a/packages/web/src/javascripts/Components/SuperEditor/Plugins/ToolbarPlugin/ToolbarPlugin.tsx +++ b/packages/web/src/javascripts/Components/SuperEditor/Plugins/ToolbarPlugin/ToolbarPlugin.tsx @@ -366,6 +366,10 @@ const ToolbarPlugin = () => { }, []) useEffect(() => { + if (isMobile) { + return + } + const scrollerElem = activeEditor.getRootElement() const update = () => { @@ -386,7 +390,7 @@ const ToolbarPlugin = () => { scrollerElem.removeEventListener('scroll', debouncedUpdate) } } - }, [activeEditor, updateToolbarFloatingPosition]) + }, [activeEditor, isMobile, updateToolbarFloatingPosition]) useEffect(() => { return mergeRegister(