fix: upon extension error, loading spinner should be removed (#461)

* fix: upon extension error, loading spinner should be removed

* feat: show a message when an extension fails to load actions

* fix: extension state data structure

* fix: initialize extensions state

Co-authored-by: Johnny Almonte <johnny243@users.noreply.github.com>
This commit is contained in:
Johnny A
2020-09-07 07:44:52 -07:00
committed by GitHub
parent d45891569f
commit 6717907dd3
2 changed files with 52 additions and 17 deletions

View File

@@ -19,7 +19,7 @@
menu-row(
action='self.executeAction(action, extension)',
label='action.label',
ng-if='!self.isExtensionVisible(extension.uuid) && !self.isExtensionLoading(extension.uuid)',
ng-if='!self.isExtensionVisible(extension.uuid) && !self.isExtensionLoading(extension.uuid) && !self.extensionHasError(extension.uuid)',
ng-repeat='action in extension.actionsWithContextForItem(self.item) track by $index',
disabled='action.running'
spinner-class="action.running ? 'info' : null",
@@ -35,3 +35,9 @@
label="'No Actions Available'",
ng-if='extension.actionsWithContextForItem(self.item).length == 0'
)
menu-row(
faded='true',
label="'Error loading actions'",
subtitle="'Please try again later.'"
ng-if='self.extensionHasError(extension.uuid)'
)