rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Fixes issue where preferences view would not close after pressing Escape

Browse Source
This commit is contained in:
Aman Harwara
2023-02-27 14:13:39 +05:30
parent 3c1dc10504
commit 6c120ffde2
3 changed files with 7 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
packages/web/src/javascripts/Components/Preferences/PreferencesView.tsx
View File

@@ -6,7 +6,6 @@ import PreferencesCanvas from './PreferencesCanvas'
import { PreferencesProps } from './PreferencesProps'
import { useDisableBodyScrollOnMobile } from '@/Hooks/useDisableBodyScrollOnMobile'
import { useAndroidBackHandler } from '@/NativeMobileWeb/useAndroidBackHandler'
import { ESCAPE_COMMAND } from '@standardnotes/ui-services'
import Modal from '../Modal/Modal'
import { classNames } from '@standardnotes/snjs'
import { isIOS } from '@/Utils'
@@ -25,17 +24,7 @@ const PreferencesView: FunctionComponent<PreferencesProps> = ({
useEffect(() => {
menu.selectPane(viewControllerManager.preferencesController.currentPane)
const removeEscKeyObserver = application.keyboardService.addCommandHandler({
command: ESCAPE_COMMAND,
onKeyDown: (event) => {
event.preventDefault()
closePreferences()
},
})
return () => {
removeEscKeyObserver()
}
}, [menu, viewControllerManager.preferencesController.currentPane, application.keyboardService, closePreferences])
}, [menu, viewControllerManager.preferencesController.currentPane])
useDisableBodyScrollOnMobile()