refactor: blocks plugins (#1956)

packages/web/src/javascripts/Components/NotesOptions/AddTagOption.tsx

@@ -5,13 +5,13 @@ import { NavigationController } from '@/Controllers/Navigation/NavigationControl
 import { NotesController } from '@/Controllers/NotesController'
 import { KeyboardKey } from '@standardnotes/ui-services'
 import Popover from '../Popover/Popover'
-import { LinkingController } from '@/Controllers/LinkingController'
 import { IconType } from '@standardnotes/snjs'
+import { getTitleForLinkedTag } from '@/Utils/Items/Display/getTitleForLinkedTag'
+import { useApplication } from '../ApplicationView/ApplicationProvider'
 
 type Props = {
   navigationController: NavigationController
   notesController: NotesController
-  linkingController: LinkingController
   className: string
   iconClassName: string
 }
@@ -19,10 +19,10 @@ type Props = {
 const AddTagOption: FunctionComponent<Props> = ({
   navigationController,
   notesController,
-  linkingController,
   className,
   iconClassName,
 }) => {
+  const application = useApplication()
   const menuContainerRef = useRef<HTMLDivElement>(null)
   const buttonRef = useRef<HTMLButtonElement>(null)
 
@@ -79,7 +79,7 @@ const AddTagOption: FunctionComponent<Props> = ({
               className={`overflow-hidden overflow-ellipsis whitespace-nowrap
                       ${notesController.isTagInSelectedNotes(tag) ? 'font-bold' : ''}`}
             >
-              {linkingController.getTitleForLinkedTag(tag)?.longTitle}
+              {getTitleForLinkedTag(tag, application)?.longTitle}
             </span>
           </button>
         ))}

packages/web/src/javascripts/Components/NotesOptions/NotesOptions.tsx

@@ -28,7 +28,10 @@ type DeletePermanentlyButtonProps = {
 
 const DeletePermanentlyButton = ({ onClick }: DeletePermanentlyButtonProps) => (
   <button
-    className="flex w-full cursor-pointer items-center border-0 bg-transparent px-3 py-1.5 text-left text-mobile-menu-item text-text hover:bg-contrast hover:text-foreground focus:bg-info-backdrop focus:shadow-none md:text-menu-item"
+    className={classNames(
+      'flex w-full cursor-pointer items-center border-0 bg-transparent px-3 py-1.5 text-left text-mobile-menu-item',
+      'text-text hover:bg-contrast hover:text-foreground focus:bg-info-backdrop focus:shadow-none md:text-menu-item',
+    )}
     onClick={onClick}
   >
     <Icon type="close" className="mr-2 text-danger" />
@@ -183,7 +186,6 @@ const NotesOptions = ({
   application,
   navigationController,
   notesController,
-  linkingController,
   historyModalController,
   closeMenu,
 }: NotesOptionsProps) => {
@@ -353,7 +355,6 @@ const NotesOptions = ({
           className={switchClassNames}
           navigationController={navigationController}
           notesController={notesController}
-          linkingController={linkingController}
         />
       )}