From 73c65c3714ba45f72e4295372bdcc6a089c0f6c3 Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Wed, 22 Jun 2022 19:51:52 +0530 Subject: [PATCH] chore: lint warn on console.log (#1135) --- packages/web/.eslintrc | 2 +- packages/web/src/javascripts/App.tsx | 1 + .../src/javascripts/Components/PanelResizer/PanelResizer.tsx | 1 - 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/web/.eslintrc b/packages/web/.eslintrc index 0691e2ada..ebc0793e8 100644 --- a/packages/web/.eslintrc +++ b/packages/web/.eslintrc @@ -13,7 +13,7 @@ "rules": { "standard/no-callback-literal": 0, // Disable this as we have too many callbacks relying on literals "no-throw-literal": 0, - "no-console": "off", + "no-console": ["warn", { "allow": ["warn", "error"] }], "semi": 1, "camelcase": "warn", "sort-imports": "off", diff --git a/packages/web/src/javascripts/App.tsx b/packages/web/src/javascripts/App.tsx index 1236c464e..379bd44be 100644 --- a/packages/web/src/javascripts/App.tsx +++ b/packages/web/src/javascripts/App.tsx @@ -44,6 +44,7 @@ const startApplication: StartApplication = async function startApplication( enableUnfinishedFeatures: boolean, webSocketUrl: string, ) { + // eslint-disable-next-line no-console SNLog.onLog = console.log SNLog.onError = console.error let root: Root diff --git a/packages/web/src/javascripts/Components/PanelResizer/PanelResizer.tsx b/packages/web/src/javascripts/Components/PanelResizer/PanelResizer.tsx index d801b4133..58fa4024c 100644 --- a/packages/web/src/javascripts/Components/PanelResizer/PanelResizer.tsx +++ b/packages/web/src/javascripts/Components/PanelResizer/PanelResizer.tsx @@ -122,7 +122,6 @@ class PanelResizer extends Component { } override componentDidMount() { - console.log(this.resizerElementRef.current) this.resizerElementRef.current?.addEventListener('dblclick', this.onDblClick) }