rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

chore: fix types

Browse Source
This commit is contained in:
Aman Harwara
2022-11-27 16:48:30 +05:30
parent cadf03f0ef
commit 745e850a5c
6 changed files with 24 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
packages/web/src/javascripts/Components/Preferences/Panes/General/SmartViews/EditSmartViewModal.tsx
View File

@@ -7,7 +7,7 @@ import ModalDialogButtons from '@/Components/Shared/ModalDialogButtons'
import ModalDialogDescription from '@/Components/Shared/ModalDialogDescription'
import ModalDialogLabel from '@/Components/Shared/ModalDialogLabel'
import Spinner from '@/Components/Spinner/Spinner'
import { Platform, SmartViewDefaultIconName } from '@standardnotes/snjs'
import { Platform, SmartViewDefaultIconName, VectorIconNameOrEmoji } from '@standardnotes/snjs'
import { observer } from 'mobx-react-lite'
import { useCallback, useEffect, useRef, useState } from 'react'
import { EditSmartViewModalController } from './EditSmartViewModalController'
@@ -103,7 +103,7 @@ const EditSmartViewModal = ({ controller, platform }: Props) => {
<div className="p-2">
<IconPicker
selectedValue={icon || SmartViewDefaultIconName}
onIconChange={(value?: string | undefined) => {
onIconChange={(value?: VectorIconNameOrEmoji) => {
setIcon(value || SmartViewDefaultIconName)
toggleIconPicker()
}}

7
packages/web/src/javascripts/Components/Preferences/Panes/General/SmartViews/EditSmartViewModalController.tsx
View File

@@ -6,13 +6,14 @@ import {
SmartView,
SmartViewDefaultIconName,
SmartViewMutator,
VectorIconNameOrEmoji,
} from '@standardnotes/snjs'
import { confirmDialog } from '@standardnotes/ui-services'
import { action, makeObservable, observable } from 'mobx'
export class EditSmartViewModalController {
title = ''
icon: string = SmartViewDefaultIconName
icon: VectorIconNameOrEmoji = SmartViewDefaultIconName
predicateJson = ''
isPredicateJsonValid = false
isSaving = false
@@ -40,7 +41,7 @@ export class EditSmartViewModalController {
this.title = title
}
setIcon = (icon: string) => {
setIcon = (icon: VectorIconNameOrEmoji) => {
this.icon = icon
}
@@ -89,7 +90,7 @@ export class EditSmartViewModalController {
await this.application.mutator.changeAndSaveItem<SmartViewMutator>(this.view, (mutator) => {
mutator.title = this.title
mutator.iconString = this.icon || SmartViewDefaultIconName
mutator.iconString = (this.icon as string) || SmartViewDefaultIconName
mutator.predicate = JSON.parse(this.predicateJson) as PredicateJsonForm
})