chore: fix types

This commit is contained in:
Aman Harwara
2022-11-27 16:48:30 +05:30
parent cadf03f0ef
commit 745e850a5c
6 changed files with 24 additions and 18 deletions

View File

@@ -8,7 +8,7 @@ import ModalDialogButtons from '@/Components/Shared/ModalDialogButtons'
import ModalDialogDescription from '@/Components/Shared/ModalDialogDescription'
import ModalDialogLabel from '@/Components/Shared/ModalDialogLabel'
import Spinner from '@/Components/Spinner/Spinner'
import { Platform, SmartViewDefaultIconName } from '@standardnotes/snjs'
import { Platform, SmartViewDefaultIconName, VectorIconNameOrEmoji } from '@standardnotes/snjs'
import { observer } from 'mobx-react-lite'
import { useEffect, useRef, useState } from 'react'
import { AddSmartViewModalController } from './AddSmartViewModalController'
@@ -153,7 +153,7 @@ const AddSmartViewModal = ({ controller, platform }: Props) => {
<div className="p-2">
<IconPicker
selectedValue={icon || SmartViewDefaultIconName}
onIconChange={(value?: string | undefined) => {
onIconChange={(value?: VectorIconNameOrEmoji) => {
setIcon(value ?? SmartViewDefaultIconName)
toggleIconPicker()
}}

View File

@@ -1,6 +1,11 @@
import { WebApplication } from '@/Application/Application'
import { CompoundPredicateBuilderController } from '@/Components/SmartViewBuilder/CompoundPredicateBuilderController'
import { predicateFromJson, PredicateJsonForm, SmartViewDefaultIconName } from '@standardnotes/snjs'
import {
predicateFromJson,
PredicateJsonForm,
SmartViewDefaultIconName,
VectorIconNameOrEmoji,
} from '@standardnotes/snjs'
import { action, makeObservable, observable } from 'mobx'
export class AddSmartViewModalController {
@@ -9,7 +14,7 @@ export class AddSmartViewModalController {
title = ''
icon: string = SmartViewDefaultIconName
icon: VectorIconNameOrEmoji = SmartViewDefaultIconName
predicateController = new CompoundPredicateBuilderController()
@@ -49,7 +54,7 @@ export class AddSmartViewModalController {
this.title = title
}
setIcon = (icon: string) => {
setIcon = (icon: VectorIconNameOrEmoji) => {
this.icon = icon
}
@@ -84,7 +89,7 @@ export class AddSmartViewModalController {
? JSON.parse(this.customPredicateJson)
: this.predicateController.toJson()
const predicate = predicateFromJson(predicateJson as PredicateJsonForm)
await this.application.items.createSmartView(this.title, predicate, this.icon)
await this.application.items.createSmartView(this.title, predicate, this.icon as string)
this.setIsSaving(false)
this.closeModal()