fix: mobx warnings and react render phase set state error

2022-10-20 20:24:56 +05:30
parent 4f3b258363
commit 76f23e13ec
3 changed files with 7 additions and 6 deletions
--- a/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
+++ b/packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
@@ -80,12 +80,11 @@ export const TagsListItem: FunctionComponent<Props> = observer(
    const toggleChildren: MouseEventHandler = useCallback(
      (e) => {
        e.stopPropagation()
-        setShowChildren((x) => {
-          tagsState.setExpanded(tag, !x)
-          return !x
-        })
+        const shouldShowChildren = !showChildren
+        setShowChildren(shouldShowChildren)
+        tagsState.setExpanded(tag, !shouldShowChildren)
      },
-      [setShowChildren, tag, tagsState],
+      [showChildren, tag, tagsState],
    )

    const selectCurrentTag = useCallback(async () => {