rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

fix: mobx warnings and react render phase set state error

Browse Source
This commit is contained in:
Aman Harwara
2022-10-20 20:24:56 +05:30
parent 4f3b258363
commit 76f23e13ec
3 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/web/src/javascripts/Components/Tags/TagsListItem.tsx
View File

@@ -80,12 +80,11 @@ export const TagsListItem: FunctionComponent<Props> = observer(
const toggleChildren: MouseEventHandler = useCallback( const toggleChildren: MouseEventHandler = useCallback(
(e) => { (e) => {
e.stopPropagation() e.stopPropagation()
setShowChildren((x) => { const shouldShowChildren = !showChildren
tagsState.setExpanded(tag, !x) setShowChildren(shouldShowChildren)
return !x tagsState.setExpanded(tag, !shouldShowChildren)
})
}, },
[setShowChildren, tag, tagsState], [showChildren, tag, tagsState],
) )
const selectCurrentTag = useCallback(async () => { const selectCurrentTag = useCallback(async () => {

2
packages/web/src/javascripts/Controllers/ItemList/ItemListController.ts
View File

@@ -214,6 +214,8 @@ export class ItemListController
optionsSubtitle: computed, optionsSubtitle: computed,
activeControllerItem: computed, activeControllerItem: computed,
hydrateFromPersistedValue: action,
}) })
window.onresize = () => { window.onresize = () => {

2
packages/web/src/javascripts/Controllers/SelectedItemsController.ts
View File

@@ -192,7 +192,7 @@ export class SelectedItemsController
private replaceSelection = (item: ListableContentItem): void => { private replaceSelection = (item: ListableContentItem): void => {
this.deselectAll() this.deselectAll()
this.setSelectedUuids(this.selectedUuids.add(item.uuid)) runInAction(() => this.setSelectedUuids(this.selectedUuids.add(item.uuid)))
this.lastSelectedItem = item this.lastSelectedItem = item
} }