rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Component and other handler deregisterations

Browse Source
This commit is contained in:
Mo Bitar
2020-03-24 12:12:07 -05:00
parent ee7cb1fce6
commit 7aa38cbdb8
11 changed files with 476 additions and 310 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
app/assets/javascripts/directives/views/componentView.js
View File

@@ -34,13 +34,16 @@ class ComponentViewCtrl {
this.cleanUpOn();
this.cleanUpWatch = null;
this.cleanUpOn = null;
this.application.componentManager.deregisterHandler(this.themeHandlerIdentifier);
this.application.componentManager.deregisterHandler(this.identifier);
this.unregisterThemeHandler();
this.unregisterComponentHandler();
this.unregisterThemeHandler = null;
this.unregisterComponentHandler = null;
if (this.component && !this.manualDealloc) {
const dontSync = true;
this.application.componentManager.deactivateComponent(this.component, dontSync);
}
this.application.getDesktopService().deregisterUpdateObserver(this.updateObserver);
this.unregisterDesktopObserver();
this.unregisterDesktopObserver = null;
document.removeEventListener(
VISIBILITY_CHANGE_LISTENER_KEY,
this.onVisibilityChange
@@ -57,7 +60,7 @@ class ComponentViewCtrl {
};
registerPackageUpdateObserver() {
this.updateObserver = this.application.getDesktopService()
this.unregisterDesktopObserver = this.application.getDesktopService()
.registerUpdateObserver((component) => {
if (component === this.component && component.active) {
this.reloadComponent();
@@ -66,18 +69,16 @@ class ComponentViewCtrl {
}
registerComponentHandlers() {
this.themeHandlerIdentifier = 'component-view-' + Math.random();
this.application.componentManager.registerHandler({
identifier: this.themeHandlerIdentifier,
this.unregisterThemeHandler = this.application.componentManager.registerHandler({
identifier: 'component-view-' + Math.random(),
areas: ['themes'],
activationHandler: (component) => {
}
});
this.identifier = 'component-view-' + Math.random();
this.application.componentManager.registerHandler({
identifier: this.identifier,
this.unregisterComponentHandler = this.application.componentManager.registerHandler({
identifier: 'component-view-' + Math.random(),
areas: [this.component.area],
activationHandler: (component) => {
if (component !== this.component) {

10
app/assets/javascripts/directives/views/revisionPreviewModal.js
View File

@@ -19,8 +19,9 @@ class RevisionPreviewModalCtrl {
}
$onDestroy() {
if (this.identifier) {
this.application.componentManager.deregisterHandler(this.identifier);
if (this.unregisterComponent) {
this.unregisterComponent();
this.unregisterComponent = null;
}
}
@@ -49,9 +50,8 @@ class RevisionPreviewModalCtrl {
});
editorCopy.readonly = true;
editorCopy.lockReadonly = true;
this.identifier = editorCopy.uuid;
this.application.componentManager.registerHandler({
identifier: this.identifier,
this.unregisterComponent = this.application.componentManager.registerHandler({
identifier: editorCopy.uuid,
areas: ['editor-editor'],
contextRequestHandler: (component) => {
if (component === this.editor) {