From 7f4bcdeec5435c71667354e33a48ea9b470637f4 Mon Sep 17 00:00:00 2001
From: Baptiste Grob <60621355+baptiste-grob@users.noreply.github.com>
Date: Wed, 7 Oct 2020 12:35:21 +0200
Subject: [PATCH] fix: reorganize action to prevent deploying when tsc fails

---
 .github/workflows/dev.yml             | 19 +++++++++++++++++++
 .github/workflows/{tsc.yml => pr.yml} |  6 +-----
 2 files changed, 20 insertions(+), 5 deletions(-)
 rename .github/workflows/{tsc.yml => pr.yml} (78%)

diff --git a/.github/workflows/dev.yml b/.github/workflows/dev.yml
index 7a855df9d..de1da606c 100644
--- a/.github/workflows/dev.yml
+++ b/.github/workflows/dev.yml
@@ -5,10 +5,29 @@ on:
     branches: [ develop ]
 
 jobs:
+
+  tsc:
+
+    name: Check types
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Install dependencies
+        run: npm ci
+
+      - name: Typescript
+        run: npm run tsc
+
   deploy:
 
     runs-on: ubuntu-latest
 
+    needs: tsc
+
     steps:
     - uses: actions/checkout@v2
 
diff --git a/.github/workflows/tsc.yml b/.github/workflows/pr.yml
similarity index 78%
rename from .github/workflows/tsc.yml
rename to .github/workflows/pr.yml
index 5033d0a12..744200fca 100644
--- a/.github/workflows/tsc.yml
+++ b/.github/workflows/pr.yml
@@ -1,10 +1,6 @@
-name: Typescript check
+name: Check pull request
 
 on:
-  push:
-    branches:
-      - develop
-      - master
   pull_request:
     branches:
       - develop