fix: deactivate themes on deinit

2020-09-24 19:08:45 -05:00
parent e177dcac47
commit 83771339a5
3 changed files with 14 additions and 4 deletions
--- a/app/assets/javascripts/services/themeManager.ts
+++ b/app/assets/javascripts/services/themeManager.ts
@@ -35,6 +35,7 @@ export class ThemeManager extends ApplicationService {
  }

  deinit() {
+    this.clearAppThemeState();
    this.unsubState?.();
    (this.unsubState as any) = undefined;
    this.activeThemes.length = 0;
@@ -89,10 +90,14 @@ export class ThemeManager extends ApplicationService {
    })
  }

-  private deactivateAllThemes() {
+  private clearAppThemeState() {
    for (const uuid of this.activeThemes) {
      this.deactivateTheme(uuid, false);
    }
+  }
+
+  private deactivateAllThemes() {
+    this.clearAppThemeState();
    this.activeThemes = [];
    this.decacheThemes();
  }