rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: Shows informative error on UI when file upload limit is reached (#2961)

Browse Source
This commit is contained in:
Antonella Sgarlatta
2025-12-18 09:49:27 -03:00
committed by GitHub
parent 5d1f6ca963
commit 844b7a7a2b
5 changed files with 19 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/services/src/Domain/Files/FileService.ts
View File

@@ -227,7 +227,11 @@ export class FileService extends AbstractService implements FilesClientInterface
vault && vault.isSharedVaultListing() ? 'shared-vault' : 'user',
)
if (isErrorResponse(uploadSessionStarted) || !uploadSessionStarted.data.uploadId) {
if (isErrorResponse(uploadSessionStarted)) {
return ClientDisplayableError.FromNetworkError(uploadSessionStarted)
}
if (!uploadSessionStarted.data.uploadId) {
return new ClientDisplayableError('Could not start upload session')
}
@@ -259,6 +263,10 @@ export class FileService extends AbstractService implements FilesClientInterface
operation.vault && operation.vault.isSharedVaultListing() ? 'shared-vault' : 'user',
)
if (uploadSessionClosed instanceof ClientDisplayableError) {
return uploadSessionClosed
}
if (!uploadSessionClosed) {
return new ClientDisplayableError('Could not close upload session')
}