tests: fix memory leaks (#2389)

packages/snjs/mocha/app-group.test.js

@@ -1,23 +1,32 @@
-/* eslint-disable no-unused-expressions */
-/* eslint-disable no-undef */
 import WebDeviceInterface from './lib/web_device_interface.js'
 import * as Factory from './lib/factory.js'
+
 chai.use(chaiAsPromised)
 const expect = chai.expect
 
 describe('application group', function () {
-  const globalDevice = new WebDeviceInterface(setTimeout.bind(window), setInterval.bind(window))
+  let device
+  let group
 
   beforeEach(async function () {
     localStorage.clear()
+
+    device = new WebDeviceInterface(setTimeout.bind(window), setInterval.bind(window))
+    group = new SNApplicationGroup(device)
   })
 
   afterEach(async function () {
+    if (group.primaryApplication) {
+      await Factory.safeDeinit(group.primaryApplication)
+    }
+    device.deinit()
+
     localStorage.clear()
+
+    group = undefined
   })
 
   it('initializing a group should result with primary application', async function () {
-    const group = new SNApplicationGroup(globalDevice)
     await group.initialize({
       applicationCreator: (descriptor, deviceInterface) => {
         return Factory.createApplicationWithFakeCrypto(descriptor.identifier, deviceInterface)
@@ -25,12 +34,9 @@ describe('application group', function () {
     })
     expect(group.primaryApplication).to.be.ok
     expect(group.primaryApplication.identifier).to.be.ok
-
-    await Factory.safeDeinit(group.primaryApplication)
   })
 
   it('initializing a group should result with proper descriptor setup', async function () {
-    const group = new SNApplicationGroup(globalDevice)
     await group.initialize({
       applicationCreator: (descriptor, deviceInterface) => {
         return Factory.createApplicationWithFakeCrypto(descriptor.identifier, deviceInterface)
@@ -38,12 +44,9 @@ describe('application group', function () {
     })
     const identifier = group.primaryApplication.identifier
     expect(group.descriptorRecord[identifier].identifier).to.equal(identifier)
-
-    await Factory.safeDeinit(group.primaryApplication)
   })
 
   it('should persist descriptor record after changes', async function () {
-    const group = new SNApplicationGroup(globalDevice)
     await group.initialize({
       applicationCreator: (descriptor, device) => {
         return Factory.createInitAppWithFakeCryptoWithOptions({
@@ -59,14 +62,13 @@ describe('application group', function () {
     expect(descriptorRecord[identifier].primary).to.equal(true)
 
     await group.unloadCurrentAndCreateNewDescriptor()
-    const descriptorRecord2 = await globalDevice.getJsonParsedRawStorageValue(RawStorageKey.DescriptorRecord)
+    const descriptorRecord2 = await device.getJsonParsedRawStorageValue(RawStorageKey.DescriptorRecord)
     expect(Object.keys(descriptorRecord2).length).to.equal(2)
 
     expect(descriptorRecord2[identifier].primary).to.equal(false)
   })
 
   it('adding new application should incrememnt total descriptor count', async function () {
-    const group = new SNApplicationGroup(globalDevice)
     await group.initialize({
       applicationCreator: (descriptor, device) => {
         return Factory.createInitAppWithFakeCryptoWithOptions({
@@ -82,7 +84,6 @@ describe('application group', function () {
   })
 
   it('should be notified when application changes', async function () {
-    const group = new SNApplicationGroup(globalDevice)
     let notifyCount = 0
     const expectedCount = 2
     // eslint-disable-next-line no-async-promise-executor