From 89491870eb37b26c5dd42f576df40813c0bd7cb2 Mon Sep 17 00:00:00 2001
From: Aman Harwara <amanharwara@protonmail.com>
Date: Wed, 28 Feb 2024 21:05:06 +0530
Subject: [PATCH] chore: make super item links wrap like normal links

---
 .../LinkedItems/LinkedItemBubble.tsx          | 50 +++++++++++++++++--
 .../Nodes/BubbleComponent.tsx                 |  3 +-
 2 files changed, 47 insertions(+), 6 deletions(-)

diff --git a/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx b/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx
index 690c95076..bfcc74c39 100644
--- a/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx
+++ b/packages/web/src/javascripts/Components/LinkedItems/LinkedItemBubble.tsx
@@ -24,6 +24,7 @@ type Props = {
   inlineFlex?: boolean
   className?: string
   readonly?: boolean
+  wrappable?: boolean
 }
 
 const LinkedItemBubble = ({
@@ -38,12 +39,13 @@ const LinkedItemBubble = ({
   inlineFlex,
   className,
   readonly,
+  wrappable,
 }: Props) => {
-  const ref = useRef<HTMLButtonElement>(null)
+  const ref = useRef<HTMLElement>()
   const application = useApplication()
 
   const [showUnlinkButton, setShowUnlinkButton] = useState(false)
-  const unlinkButtonRef = useRef<HTMLAnchorElement | null>(null)
+  const unlinkButtonRef = useRef<HTMLElement>()
 
   const [wasClicked, setWasClicked] = useState(false)
 
@@ -101,11 +103,49 @@ const LinkedItemBubble = ({
     }
   }, [focusedId, link.id])
 
+  if (wrappable) {
+    return (
+      <a
+        ref={(el) => (ref.current = el as HTMLElement)}
+        tabIndex={0}
+        className={classNames(
+          'group cursor-pointer rounded align-middle [&>*]:align-middle',
+          'bg-passive-4-opacity-variant outline-1 outline-info hover:bg-contrast focus:bg-contrast focus:outline',
+          'whitespace-pre-wrap text-left text-sm text-text hover:no-underline focus:no-underline lg:text-xs',
+          'py-1 pl-1 pr-2',
+          className,
+        )}
+        onFocus={handleFocus}
+        onBlur={onBlur}
+        onClick={onClick}
+        title={tagTitle ? tagTitle.longTitle : link.item.title}
+        onKeyDown={onKeyDown}
+      >
+        <Icon type={icon} className={classNames('mr-1 inline', iconClassName)} size="small" />
+        {tagTitle && <span className="text-passive-1">{tagTitle.titlePrefix}</span>}
+        {link.type === 'linked-by' && link.item.content_type !== ContentType.TYPES.Tag && (
+          <span className={!isBidirectional ? 'hidden group-focus:inline' : ''}>Linked By:</span>
+        )}
+        <span>{getItemTitleInContextOfLinkBubble(link.item)}</span>
+        {showUnlinkButton && !readonly && (
+          <button
+            ref={(el) => (unlinkButtonRef.current = el as HTMLElement)}
+            role="button"
+            className="-mr-1 ml-2 inline-flex cursor-pointer border-0 bg-transparent p-0"
+            onClick={onUnlinkClick}
+          >
+            <Icon type="close" className="text-neutral hover:text-info" size="small" />
+          </button>
+        )}
+      </a>
+    )
+  }
+
   return (
     <button
-      ref={ref}
+      ref={(el) => (ref.current = el as HTMLElement)}
       className={classNames(
-        'group h-6 cursor-pointer items-center rounded bg-passive-4-opacity-variant py-2 pl-1 pr-2 text-sm',
+        'group h-6 cursor-pointer items-center rounded bg-passive-4-opacity-variant py-2 pl-1 pr-2 align-middle text-sm',
         'text-text hover:bg-contrast focus:bg-contrast lg:text-xs',
         inlineFlex ? 'inline-flex' : 'flex',
         className,
@@ -128,7 +168,7 @@ const LinkedItemBubble = ({
       </span>
       {showUnlinkButton && !readonly && (
         <a
-          ref={unlinkButtonRef}
+          ref={(el) => (unlinkButtonRef.current = el as HTMLElement)}
           role="button"
           className="-mr-1 ml-2 flex cursor-pointer border-0 bg-transparent p-0"
           onClick={onUnlinkClick}
diff --git a/packages/web/src/javascripts/Components/SuperEditor/Plugins/ItemBubblePlugin/Nodes/BubbleComponent.tsx b/packages/web/src/javascripts/Components/SuperEditor/Plugins/ItemBubblePlugin/Nodes/BubbleComponent.tsx
index d4b0e0ffc..f310b38f7 100644
--- a/packages/web/src/javascripts/Components/SuperEditor/Plugins/ItemBubblePlugin/Nodes/BubbleComponent.tsx
+++ b/packages/web/src/javascripts/Components/SuperEditor/Plugins/ItemBubblePlugin/Nodes/BubbleComponent.tsx
@@ -48,13 +48,14 @@ export function BubbleComponent({ itemUuid, node }: BubbleComponentProps) {
 
   return (
     <LinkedItemBubble
-      className="m-1"
+      className="mx-0.5"
       link={link}
       key={link.id}
       activateItem={activateItemAndTogglePane}
       unlinkItem={unlinkPressed}
       isBidirectional={false}
       inlineFlex={true}
+      wrappable
     />
   )
 }