chore(web): put sign-in email notifications setting under paywall (#2249)

* chore: upgrade setting names to value objects

* chore(web): put sign-in email notifications setting under paywall

* chore: fix using setting name value objects in mocha tests

* chore: fix wording on email notifications titles

packages/web/src/javascripts/Components/Preferences/Panes/Backups/CloudBackups/CloudBackupProvider.tsx

@@ -82,18 +82,18 @@ const CloudBackupProvider: FunctionComponent<Props> = ({ application, providerNa
 
   const backupSettingsData = {
     [CloudProvider.Dropbox]: {
-      backupTokenSettingName: SettingName.DropboxBackupToken,
-      backupFrequencySettingName: SettingName.DropboxBackupFrequency,
+      backupTokenSettingName: SettingName.create(SettingName.NAMES.DropboxBackupToken).getValue(),
+      backupFrequencySettingName: SettingName.create(SettingName.NAMES.DropboxBackupFrequency).getValue(),
       defaultBackupFrequency: DropboxBackupFrequency.Daily,
     },
     [CloudProvider.Google]: {
-      backupTokenSettingName: SettingName.GoogleDriveBackupToken,
-      backupFrequencySettingName: SettingName.GoogleDriveBackupFrequency,
+      backupTokenSettingName: SettingName.create(SettingName.NAMES.GoogleDriveBackupToken).getValue(),
+      backupFrequencySettingName: SettingName.create(SettingName.NAMES.GoogleDriveBackupFrequency).getValue(),
       defaultBackupFrequency: GoogleDriveBackupFrequency.Daily,
     },
     [CloudProvider.OneDrive]: {
-      backupTokenSettingName: SettingName.OneDriveBackupToken,
-      backupFrequencySettingName: SettingName.OneDriveBackupFrequency,
+      backupTokenSettingName: SettingName.create(SettingName.NAMES.OneDriveBackupToken).getValue(),
+      backupFrequencySettingName: SettingName.create(SettingName.NAMES.OneDriveBackupFrequency).getValue(),
       defaultBackupFrequency: OneDriveBackupFrequency.Daily,
     },
   }

packages/web/src/javascripts/Components/Preferences/Panes/Backups/CloudBackups/CloudBackups.tsx

@@ -41,7 +41,7 @@ const CloudLink: FunctionComponent<Props> = ({ application }) => {
       setIsFailedCloudBackupEmailMuted(
         convertStringifiedBooleanToBoolean(
           userSettings.getSettingValue(
-            SettingName.MuteFailedCloudBackupsEmails,
+            SettingName.create(SettingName.NAMES.MuteFailedCloudBackupsEmails).getValue(),
             MuteFailedCloudBackupsEmailsOption.NotMuted,
           ),
         ),
@@ -83,7 +83,7 @@ const CloudLink: FunctionComponent<Props> = ({ application }) => {
     setIsFailedCloudBackupEmailMuted(!isFailedCloudBackupEmailMuted)
 
     const updateResult = await updateSetting(
-      SettingName.MuteFailedCloudBackupsEmails,
+      SettingName.create(SettingName.NAMES.MuteFailedCloudBackupsEmails).getValue(),
       `${!isFailedCloudBackupEmailMuted}`,
     )
     if (!updateResult) {

packages/web/src/javascripts/Components/Preferences/Panes/Backups/EmailBackups.tsx

@@ -34,14 +34,14 @@ const EmailBackups = ({ application }: Props) => {
       const userSettings = await application.settings.listSettings()
       setEmailFrequency(
         userSettings.getSettingValue<EmailBackupFrequency>(
-          SettingName.EmailBackupFrequency,
+          SettingName.create(SettingName.NAMES.EmailBackupFrequency).getValue(),
           EmailBackupFrequency.Disabled,
         ),
       )
       setIsFailedBackupEmailMuted(
         convertStringifiedBooleanToBoolean(
           userSettings.getSettingValue<MuteFailedBackupsEmailsOption>(
-            SettingName.MuteFailedBackupsEmails,
+            SettingName.create(SettingName.NAMES.MuteFailedBackupsEmails).getValue(),
             MuteFailedBackupsEmailsOption.NotMuted,
           ),
         ),
@@ -81,7 +81,10 @@ const EmailBackups = ({ application }: Props) => {
     const previousFrequency = emailFrequency
     setEmailFrequency(frequency)
 
-    const updateResult = await updateSetting(SettingName.EmailBackupFrequency, frequency)
+    const updateResult = await updateSetting(
+      SettingName.create(SettingName.NAMES.EmailBackupFrequency).getValue(),
+      frequency,
+    )
     if (!updateResult) {
       setEmailFrequency(previousFrequency)
     }
@@ -91,7 +94,10 @@ const EmailBackups = ({ application }: Props) => {
     const previousValue = isFailedBackupEmailMuted
     setIsFailedBackupEmailMuted(!isFailedBackupEmailMuted)
 
-    const updateResult = await updateSetting(SettingName.MuteFailedBackupsEmails, `${!isFailedBackupEmailMuted}`)
+    const updateResult = await updateSetting(
+      SettingName.create(SettingName.NAMES.MuteFailedBackupsEmails).getValue(),
+      `${!isFailedBackupEmailMuted}`,
+    )
     if (!updateResult) {
       setIsFailedBackupEmailMuted(previousValue)
     }