From 93fbfffbd24c7943b8beec53d91c89d69f333073 Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Tue, 26 Apr 2022 19:56:26 +0530 Subject: [PATCH] fix: spinner loading infinitely on unsupported file types (#1002) --- app/assets/javascripts/Components/Files/FilePreviewModal.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/assets/javascripts/Components/Files/FilePreviewModal.tsx b/app/assets/javascripts/Components/Files/FilePreviewModal.tsx index 248701fa5..3bc028301 100644 --- a/app/assets/javascripts/Components/Files/FilePreviewModal.tsx +++ b/app/assets/javascripts/Components/Files/FilePreviewModal.tsx @@ -50,6 +50,10 @@ export const FilePreviewModal: FunctionComponent = ({ application, file, const isPreviewable = isFileTypePreviewable(file.mimeType) setIsFilePreviewable(isPreviewable) + if (!isPreviewable) { + setIsLoadingFile(false) + } + if (!objectUrl && isPreviewable) { getObjectUrl().catch(console.error) }