rmorawski/standardnotes-app-web
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

refactor: fix noteviewcontroller de-init

Browse Source
This commit is contained in:
Aman Harwara
2023-03-22 15:58:44 +05:30
parent 151cfd2fe4
commit 9adfb0a925
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/web/src/javascripts/Components/NoteView/Controller/NoteViewController.ts
View File

@@ -38,7 +38,7 @@ export class NoteViewController implements ItemViewControllerInterface {
private saveTimeout?: ReturnType<typeof setTimeout> private saveTimeout?: ReturnType<typeof setTimeout>
private defaultTagUuid: UuidString | undefined private defaultTagUuid: UuidString | undefined
private defaultTag?: SNTag private defaultTag?: SNTag
private savingLocallyPromise = Deferred<void>() private savingLocallyPromise: ReturnType<typeof Deferred<void>> | null = null
constructor( constructor(
private application: WebApplication, private application: WebApplication,
@@ -59,6 +59,11 @@ export class NoteViewController implements ItemViewControllerInterface {
} }
deinit(): void { deinit(): void {
if (!this.savingLocallyPromise) {
this.performDeinitSafely()
return
}
void this.savingLocallyPromise.promise.then(() => { void this.savingLocallyPromise.promise.then(() => {
this.performDeinitSafely() this.performDeinitSafely()
}) })
@@ -212,7 +217,9 @@ export class NoteViewController implements ItemViewControllerInterface {
void this.undebouncedSave({ void this.undebouncedSave({
...params, ...params,
onLocalPropagationComplete: () => { onLocalPropagationComplete: () => {
this.savingLocallyPromise.resolve() if (this.savingLocallyPromise) {
this.savingLocallyPromise.resolve()
}
resolve() resolve()
}, },
}) })