feat: wait 1ms before menu collision detection (#859)

app/assets/javascripts/components/NotesOptions/ChangeEditorOption.tsx

@@ -27,7 +27,7 @@ import {
   TransactionalMutation,
 } from '@standardnotes/snjs';
 import { FunctionComponent } from 'preact';
-import { useEffect, useLayoutEffect, useRef, useState } from 'preact/hooks';
+import { useEffect, useRef, useState } from 'preact/hooks';
 import { Icon } from '../Icon';
 import { createEditorMenuGroups } from './changeEditor/createEditorMenuGroups';
 import { EditorAccordionMenu } from './changeEditor/EditorAccordionMenu';
@@ -111,7 +111,7 @@ const calculateMenuPosition = (
     }
   }
 
-  if (menuBoundingRect && buttonRect) {
+  if (menuBoundingRect && menuBoundingRect.height && buttonRect) {
     if (menuBoundingRect.y < MENU_MARGIN_FROM_APP_BORDER) {
       if (
         buttonRect.right + maxChangeEditorMenuSize >
@@ -130,11 +130,13 @@ const calculateMenuPosition = (
         };
       }
     }
-  } else {
-    return position;
   }
+
+  return position;
 };
 
+const TIME_IN_MS_TO_WAIT_BEFORE_REPAINT = 1;
+
 export const ChangeEditorOption: FunctionComponent<ChangeEditorOptionProps> = ({
   application,
   appState,
@@ -182,16 +184,18 @@ export const ChangeEditorOption: FunctionComponent<ChangeEditorOptionProps> = ({
     setChangeEditorMenuOpen(!changeEditorMenuOpen);
   };
 
-  useLayoutEffect(() => {
+  useEffect(() => {
     if (changeEditorMenuOpen) {
-      const newMenuPosition = calculateMenuPosition(
+      setTimeout(() => {
-        changeEditorButtonRef.current,
+        const newMenuPosition = calculateMenuPosition(
-        changeEditorMenuRef.current
+          changeEditorButtonRef.current,
-      );
+          changeEditorMenuRef.current
+        );
 
-      if (newMenuPosition) {
+        if (newMenuPosition) {
-        setChangeEditorMenuPosition(newMenuPosition);
+          setChangeEditorMenuPosition(newMenuPosition);
-      }
+        }
+      }, TIME_IN_MS_TO_WAIT_BEFORE_REPAINT);
     }
   }, [changeEditorMenuOpen]);