From 9d532e83e1e5d0181e4a84f8b999221b9fc1e68a Mon Sep 17 00:00:00 2001 From: Aman Harwara Date: Thu, 9 Nov 2023 18:49:48 +0530 Subject: [PATCH] chore: potential fix for unintentional multiple selection after editing on ios [skip e2e] --- .../javascripts/Components/ContentListView/NoteListItem.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/web/src/javascripts/Components/ContentListView/NoteListItem.tsx b/packages/web/src/javascripts/Components/ContentListView/NoteListItem.tsx index 1d77e67de..d43a1a0e0 100644 --- a/packages/web/src/javascripts/Components/ContentListView/NoteListItem.tsx +++ b/packages/web/src/javascripts/Components/ContentListView/NoteListItem.tsx @@ -78,7 +78,8 @@ const NoteListItem: FunctionComponent> = ({ const onClick = useCallback( (event: MouseEvent) => { - if ((event.ctrlKey || event.metaKey) && !application.itemListController.isMultipleSelectionMode) { + const hasMultiSelectionModifierKey = !isMobileScreen && (event.ctrlKey || event.metaKey) + if (hasMultiSelectionModifierKey && !application.itemListController.isMultipleSelectionMode) { application.itemListController.enableMultipleSelectionMode() } if (selected && !application.itemListController.isMultipleSelectionMode) { @@ -87,7 +88,7 @@ const NoteListItem: FunctionComponent> = ({ } onSelect(item, true).catch(console.error) }, - [application.itemListController, item, onSelect, selected], + [application.itemListController, isMobileScreen, item, onSelect, selected], ) useContextMenuEvent(listItemRef, handleContextMenuEvent)